Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Unified Diff: chrome/browser/ssl/ssl_blocking_page.cc

Issue 2966903002: Specialize Superfish interstitial metrics (Closed)
Patch Set: string -> const char[] Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ssl/ssl_browser_tests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/ssl_blocking_page.cc
diff --git a/chrome/browser/ssl/ssl_blocking_page.cc b/chrome/browser/ssl/ssl_blocking_page.cc
index 872d405c3f76071be7600452856c58854e9f2aee..af4695e2b6a25c0d837b9e24caf17e4f50dc94a8 100644
--- a/chrome/browser/ssl/ssl_blocking_page.cc
+++ b/chrome/browser/ssl/ssl_blocking_page.cc
@@ -99,10 +99,15 @@ std::unique_ptr<ChromeMetricsHelper> CreateMetricsHelper(
content::WebContents* web_contents,
int cert_error,
const GURL& request_url,
- bool overridable) {
+ bool overridable,
+ bool is_superfish) {
security_interstitials::MetricsHelper::ReportDetails reporting_info;
- reporting_info.metric_prefix =
- overridable ? "ssl_overridable" : "ssl_nonoverridable";
+ if (is_superfish) {
+ reporting_info.metric_prefix = "superfish";
+ } else {
+ reporting_info.metric_prefix =
+ overridable ? "ssl_overridable" : "ssl_nonoverridable";
+ }
return base::MakeUnique<ChromeMetricsHelper>(
web_contents, request_url, reporting_info,
GetSamplingEventName(overridable, cert_error));
@@ -143,8 +148,8 @@ SSLBlockingPage* SSLBlockingPage::Create(
else
options_mask &= ~SSLErrorUI::SOFT_OVERRIDE_ENABLED;
- std::unique_ptr<ChromeMetricsHelper> metrics_helper(
- CreateMetricsHelper(web_contents, cert_error, request_url, overridable));
+ std::unique_ptr<ChromeMetricsHelper> metrics_helper(CreateMetricsHelper(
+ web_contents, cert_error, request_url, overridable, is_superfish));
metrics_helper.get()->StartRecordingCaptivePortalMetrics(overridable);
return new SSLBlockingPage(web_contents, cert_error, ssl_info, request_url,
« no previous file with comments | « no previous file | chrome/browser/ssl/ssl_browser_tests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698