Specialize Superfish interstitial metrics

chrome/browser/ssl/ssl_browser_tests.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <utility>
 
 #include "base/base64.h"
 #include "base/base_switches.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 4962 matching lines @@
   base::HistogramTester histograms;
   ui_test_utils::NavigateToURL(browser(),
                                https_server_.GetURL("/ssl/google.html"));
   histograms.ExpectUniqueSample("interstitial.ssl_error_handler.superfish",
                                 false, 1);
 }
 
 // Tests that the Superfish interstitial is shown when the Finch feature is
 // enabled and the Superfish certificate is present.
 IN_PROC_BROWSER_TEST_F(SuperfishSSLUITest, SuperfishInterstitial) {
+  base::HistogramTester histograms;
+  const std::string decision_histogram = "interstitial.superfish.decision";

[meacer, 2017/06/30 22:53:29]

nit: const char kDecisionHistogram[] instead? Same for interaction_histogram.

[estark, 2017/06/30 23:20:30]

Done.

+  const std::string interaction_histogram =
+      "interstitial.superfish.interaction";
+
   base::test::ScopedFeatureList scoped_feature_list;
   scoped_feature_list.InitFromCommandLine("SuperfishInterstitial",
                                           std::string());
   SetUpCertVerifier(true /* use superfish cert */);
   ui_test_utils::NavigateToURL(browser(),
                                https_server_.GetURL("/ssl/google.html"));
   content::WebContents* tab =
       browser()->tab_strip_model()->GetActiveWebContents();
   content::WaitForInterstitialAttach(tab);
   InterstitialPage* interstitial_page = tab->GetInterstitialPage();
   ASSERT_TRUE(interstitial_page);
   EXPECT_TRUE(WaitForRenderFrameReady(interstitial_page->GetMainFrame()));
   EXPECT_EQ(SSLBlockingPage::kTypeForTesting,
             interstitial_page->GetDelegateForTesting()->GetTypeForTesting());
 
   // Look for keywords on the page to check that the Superfish interstitial is
   // showing.
   const std::string expected_title =
       l10n_util::GetStringUTF8(IDS_SSL_SUPERFISH_HEADING);
   EXPECT_TRUE(chrome_browser_interstitials::IsInterstitialDisplayingText(
       interstitial_page, expected_title));
+
+  // Check that the correct histograms were recorded.
+  histograms.ExpectTotalCount(decision_histogram, 1);
+  histograms.ExpectBucketCount(decision_histogram,
+                               security_interstitials::MetricsHelper::SHOW, 1);
+  histograms.ExpectTotalCount(interaction_histogram, 1);
+  histograms.ExpectBucketCount(
+      interaction_histogram,
+      security_interstitials::MetricsHelper::TOTAL_VISITS, 1);
 }
 
 // Tests that the Superfish interstitial is not shown when the Finch feature is
 // disabled.
 IN_PROC_BROWSER_TEST_F(SuperfishSSLUITest, SuperfishInterstitialDisabled) {
   base::test::ScopedFeatureList scoped_feature_list;
   scoped_feature_list.InitFromCommandLine(std::string(),
                                           "SuperfishInterstitial");
   SetUpCertVerifier(true /* use superfish cert */);
   ui_test_utils::NavigateToURL(browser(),
@@ skipping 19 matching lines @@
 
 // Visit a page over https that contains a frame with a redirect.
 
 // XMLHttpRequest insecure content in synchronous mode.
 
 // XMLHttpRequest insecure content in asynchronous mode.
 
 // XMLHttpRequest over bad ssl in synchronous mode.
 
 // XMLHttpRequest over OK ssl in synchronous mode.