[Night Light] CL12: String changes and fix frequent requests.

chrome/browser/chromeos/night_light/night_light_client.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_NIGHT_LIGHT_NIGHT_LIGHT_CLIENT_H_
 #define CHROME_BROWSER_CHROMEOS_NIGHT_LIGHT_NIGHT_LIGHT_CLIENT_H_
 
 #include "ash/public/interfaces/night_light_controller.mojom.h"
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
@@ skipping 28 matching lines @@
       ash::mojom::NightLightControllerPtr controller);
 
   void FlushNightLightControllerForTesting();
 
  protected:
   void OnGeoposition(const chromeos::Geoposition& position,
                      bool server_error,
                      const base::TimeDelta elapsed);
 
  private:
+  void SendCurrentGeoposition();

[James Cook, 2017/06/30 19:12:26]

nit: docs (send to who?)

[afakhry, 2017/06/30 22:28:28]

Done.

+
   void ScheduleNextRequest(base::TimeDelta delay);
 
   // Virtual so that it can be overriden by a fake implementation in unit tests
   // that doesn't request actual geopositions.
   virtual void RequestGeoposition();
 
   // The IP-based geolocation provider.
   chromeos::SimpleGeolocationProvider provider_;
 
   ash::mojom::NightLightControllerPtr night_light_controller_;
   mojo::Binding<ash::mojom::NightLightClient> binding_;
 
   // Delay after which a new request is retried after a failed one.
   base::TimeDelta backoff_delay_;
 
   base::OneShotTimer timer_;
 
+  // Last successful geoposition coordinates and its timestamp.
+  base::Time last_successful_request_;

[James Cook, 2017/06/30 19:12:26]

optional: maybe |last_successful_geo_request_|?

[afakhry, 2017/06/30 22:28:28]

Done. Actually named it |last_successful_geo_request_time_|.

+  double latitude_ = 0.0;
+  double longitude_ = 0.0;
+
   // True as long as the schedule type is set to "sunset to sunrise", which
   // means this client will be retrieving the IP-based geoposition once per day.
   bool using_geoposition_ = false;
 
   DISALLOW_COPY_AND_ASSIGN(NightLightClient);
 };
 
 #endif  // CHROME_BROWSER_CHROMEOS_NIGHT_LIGHT_NIGHT_LIGHT_CLIENT_H_