Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: chrome/browser/android/signin/signin_manager_android_unittest.cc

Issue 2966763003: [Prototype] Delete Google service worker caches on Android signout (Closed)
Patch Set: Only delete the cache. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/signin/signin_manager_android_unittest.cc
diff --git a/chrome/browser/android/signin/signin_manager_android_unittest.cc b/chrome/browser/android/signin/signin_manager_android_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..eb0c47fd9e12e079ec2750e3a2ca23e08e0a1801
--- /dev/null
+++ b/chrome/browser/android/signin/signin_manager_android_unittest.cc
@@ -0,0 +1,97 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "signin_manager_android.h"
+
+#include <memory>
+#include <set>
+
+#include "base/memory/ref_counted.h"
+#include "base/run_loop.h"
+#include "chrome/browser/browsing_data/browsing_data_cache_storage_helper.h"
+#include "chrome/test/base/testing_browser_process.h"
+#include "chrome/test/base/testing_profile_manager.h"
+#include "content/public/browser/browser_context.h"
+#include "content/public/browser/browsing_data_remover.h"
+#include "content/public/browser/storage_partition.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+class SigninManagerAndroidTest : public ::testing::Test {
+ public:
+ SigninManagerAndroidTest()
+ : profile_manager_(TestingBrowserProcess::GetGlobal()) {}
+ ~SigninManagerAndroidTest() override{};
+
+ void SetUp() override {
+ ASSERT_TRUE(profile_manager_.SetUp());
+ profile_ = profile_manager_.CreateTestingProfile("Testing Profile");
+ }
+
+ TestingProfile* profile() { return profile_; }
+
+ private:
+ content::TestBrowserThreadBundle thread_bundle_;
+ TestingProfileManager profile_manager_;
+ TestingProfile* profile_; // Owned by |profile_manager_|.
+
+ DISALLOW_COPY_AND_ASSIGN(SigninManagerAndroidTest);
+};
+
+TEST_F(SigninManagerAndroidTest, DeleteGoogleServiceWorkerCaches) {
+ struct TestCase {
+ std::string worker_url;
+ bool should_be_deleted;
+ } kTestCases[] = {
+ // A Google domain.
+ {"https://google.com/foo/bar", true},
+
+ // A Google domain with long TLD.
+ {"https://plus.google.co.uk/?query_params", true},
+
+ // Youtube.
+ {"https://youtube.com", false},
+
+ // A random domain.
+ {"https://a.b.c.example.com", false},
+
+ // Another Google domain.
+ {"https://www.google.de/worker.html", true},
+
+ // Ports don't matter, only TLDs.
+ {"https://google.com:8444/worker.html", true},
+ };
+
+ // Add service workers.
+ scoped_refptr<CannedBrowsingDataCacheStorageHelper> helper(
+ new CannedBrowsingDataCacheStorageHelper(
+ content::BrowserContext::GetDefaultStoragePartition(profile())
+ ->GetCacheStorageContext()));
+
+ for (const TestCase& test_case : kTestCases)
+ helper->AddCacheStorage(GURL(test_case.worker_url));
+
+ ASSERT_EQ(arraysize(kTestCases), helper->GetCacheStorageCount());
+
+ // Delete service workers and wait for completion.
+ base::RunLoop run_loop;
+ SigninManagerAndroid::WipeData(profile(),
+ false /* only service worker caches */,
+ run_loop.QuitClosure());
+ run_loop.Run();
+
+ // Test whether the correct service worker caches were deleted.
+ std::set<std::string> remaining_cache_storages;
+ for (const auto& info : helper->GetCacheStorageUsageInfo())
+ remaining_cache_storages.insert(info.origin.spec());
+
+ for (const TestCase& test_case : kTestCases) {
+ EXPECT_EQ(test_case.should_be_deleted,
+ base::ContainsKey(remaining_cache_storages, test_case.worker_url))
+ << test_case.worker_url << " should "
+ << (test_case.should_be_deleted ? "" : "NOT ")
+ << "be deleted, but it was"
+ << (test_case.should_be_deleted ? "NOT" : "") << ".";
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698