Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2003)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java

Issue 2966763003: [Prototype] Delete Google service worker caches on Android signout (Closed)
Patch Set: Only delete the cache. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java b/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java
index 2d040ff73efbd5856547f370ba73dd3a8e339e88..2317120e8a45f730f9941e5c7efc2fa28c476a7f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java
@@ -540,7 +540,7 @@ public class SigninManager implements AccountTrackerService.OnSystemAccountsSeed
if (wipeData) {
wipeProfileData(wipeDataHooks);
} else {
- onSignOutDone();
+ wipeGoogleServiceWorkers(wipeDataHooks);
gogerald1 2017/07/13 17:08:22 nit:WipeGoogleServiceWorkerCaches?
msramek 2017/07/13 19:09:12 Done. Missed this :)
}
AccountTrackerService.get().invalidateAccountSeedStatus(true);
@@ -592,6 +592,12 @@ public class SigninManager implements AccountTrackerService.OnSystemAccountsSeed
nativeWipeProfileData(mNativeSigninManagerAndroid, hooks);
}
+ private void wipeGoogleServiceWorkers(WipeDataHooks hooks) {
+ if (hooks != null) hooks.preWipeData();
+ // This will call back to onProfileDataWiped().
+ nativeWipeGoogleServiceWorkerCaches(mNativeSigninManagerAndroid, hooks);
+ }
+
/**
* Convenience method to return a Promise to be fulfilled when the user's sync data has been
* wiped if the parameter is true, or an already fulfilled Promise if the parameter is false.
@@ -679,6 +685,8 @@ public class SigninManager implements AccountTrackerService.OnSystemAccountsSeed
private native void nativeSignOut(long nativeSigninManagerAndroid);
private native String nativeGetManagementDomain(long nativeSigninManagerAndroid);
private native void nativeWipeProfileData(long nativeSigninManagerAndroid, WipeDataHooks hooks);
+ private native void nativeWipeGoogleServiceWorkerCaches(
+ long nativeSigninManagerAndroid, WipeDataHooks hooks);
private native void nativeClearLastSignedInUser(long nativeSigninManagerAndroid);
private native void nativeLogInSignedInUser(long nativeSigninManagerAndroid);
private native boolean nativeIsSignedInOnNative(long nativeSigninManagerAndroid);

Powered by Google App Engine
This is Rietveld 408576698