Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Unified Diff: media/mojo/common/mojo_media_log_service.cc

Issue 2966643002: media: Plumb MediaLog to MojoVideoDecoderService. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/mojo/common/mojo_media_log_service.cc
diff --git a/media/mojo/common/mojo_media_log_service.cc b/media/mojo/common/mojo_media_log_service.cc
new file mode 100644
index 0000000000000000000000000000000000000000..932a02e30c02b72ea442b5e85a436a430a6290d4
--- /dev/null
+++ b/media/mojo/common/mojo_media_log_service.cc
@@ -0,0 +1,37 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "media/mojo/common/mojo_media_log_service.h"
+
+#include <memory>
+
+#include "base/logging.h"
+#include "base/memory/ptr_util.h"
+#include "media/base/media_log_event.h"
+
+namespace media {
+
+MojoMediaLogService::MojoMediaLogService(media::MediaLog* media_log)
+ : media_log_(media_log) {
+ DVLOG(1) << __func__;
+ DCHECK(media_log_);
+
+ std::unique_ptr<media::MediaLogEvent> event =
+ media_log_->CreateEvent(media::MediaLogEvent::WEBMEDIAPLAYER_CREATED);
+ id_ = event->id;
xhwang 2017/06/30 16:24:57 How about adding an access to get the ID from |med
sandersd (OOO until July 31) 2017/06/30 17:44:30 I did this by exposing a getter, since MediaLog ca
+}
+
+MojoMediaLogService::~MojoMediaLogService() {
+ DVLOG(1) << __func__;
+}
+
+void MojoMediaLogService::AddEvent(const media::MediaLogEvent& event) {
+ DVLOG(1) << __func__;
+ std::unique_ptr<media::MediaLogEvent> modified_event =
+ base::MakeUnique<media::MediaLogEvent>(event);
+ modified_event->id = id_;
xhwang 2017/06/30 16:24:57 This worth some comment (e.g. the ID is per proces
sandersd (OOO until July 31) 2017/06/30 17:44:30 Done.
+ media_log_->AddEvent(std::move(modified_event));
+}
+
+} // namespace media

Powered by Google App Engine
This is Rietveld 408576698