Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1404)

Issue 2966623003: Add the tests of the spec generator to the unit tests (Closed)

Created:
3 years, 5 months ago by Brian Wilkerson
Modified:
3 years, 5 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -4 lines) Patch
M pkg/analysis_server/test/test_all.dart View 2 chunks +11 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/check_all_test.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M pkg/analyzer_plugin/test/test_all.dart View 2 chunks +11 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/tool/spec/check_all_test.dart View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
These tests are not currently being run anywhere. This will cause them to at least ...
3 years, 5 months ago (2017-06-30 16:45:55 UTC) #2
scheglov
LGTM
3 years, 5 months ago (2017-06-30 16:53:45 UTC) #3
Brian Wilkerson
3 years, 5 months ago (2017-06-30 17:08:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6248df44a6308eb7bcdba28455e005cf7a625e35 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698