Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Issue 2966603002: Minor fixes to for-loop type inference (Closed)

Created:
3 years, 5 months ago by Paul Berry
Modified:
3 years, 5 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -3 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 1 chunk +4 lines, -2 lines 0 comments Download
A pkg/front_end/testcases/inference/for_loop_empty_condition.dart View 1 chunk +17 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/for_loop_empty_condition.dart.dartk.expect View 1 chunk +15 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/for_loop_empty_condition.dart.direct.expect View 1 chunk +15 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/for_loop_empty_condition.dart.outline.expect View 1 chunk +7 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/for_loop_empty_condition.dart.strong.expect View 1 chunk +15 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/for_loop_initializer_expression.dart View 1 chunk +17 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/for_loop_initializer_expression.dart.dartk.expect View 1 chunk +16 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/for_loop_initializer_expression.dart.direct.expect View 1 chunk +16 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/for_loop_initializer_expression.dart.outline.expect View 1 chunk +7 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/for_loop_initializer_expression.dart.strong.expect View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 5 months ago (2017-06-29 21:29:42 UTC) #2
scheglov
LGTM
3 years, 5 months ago (2017-06-29 21:33:12 UTC) #3
Paul Berry
3 years, 5 months ago (2017-06-29 21:35:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d0a8b78576f580f4a4f46f5abbdd0528c2360ead (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698