Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 2966583002: Mark class as typedef class before parsing its function type when using the new (Closed)

Created:
3 years, 5 months ago by regis
Modified:
3 years, 5 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[VM parser] Mark class as typedef class before parsing its function type when using the new function type syntax. This issue prevents committing of https://codereview.chromium.org/2893893002 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/164a602a809d53cea75a8899f7ed861ec6e684d7

Patch Set 1 #

Total comments: 2

Patch Set 2 : work in progress #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -11 lines) Patch
M runtime/vm/class_finalizer.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/parser.cc View 1 3 chunks +15 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
regis
3 years, 5 months ago (2017-06-29 20:30:01 UTC) #3
rmacnak
lgtm https://codereview.chromium.org/2966583002/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/2966583002/diff/1/runtime/vm/parser.cc#newcode5481 runtime/vm/parser.cc:5481: library_.AddClass(function_type_alias); ASSERT(function_type_alias.IsTypedefClass());
3 years, 5 months ago (2017-06-29 21:11:10 UTC) #4
regis
Thanks! https://codereview.chromium.org/2966583002/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/2966583002/diff/1/runtime/vm/parser.cc#newcode5481 runtime/vm/parser.cc:5481: library_.AddClass(function_type_alias); On 2017/06/29 21:11:09, rmacnak wrote: > ASSERT(function_type_alias.IsTypedefClass()); ...
3 years, 5 months ago (2017-06-29 21:30:47 UTC) #5
regis
3 years, 5 months ago (2017-06-29 21:33:42 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
164a602a809d53cea75a8899f7ed861ec6e684d7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698