Blink-layer update to match WebAuthN spec

third_party/WebKit/Source/modules/webauth/AuthenticatorAssertionResponse.h

Index: third_party/WebKit/Source/modules/webauth/AuthenticatorAssertionResponse.h
diff --git a/third_party/WebKit/Source/modules/webauth/AuthenticatorAssertionResponse.h b/third_party/WebKit/Source/modules/webauth/AuthenticatorAssertionResponse.h
new file mode 100644
index 0000000000000000000000000000000000000000..140f7768a54e060df1a3199419bf4da908ab9d51
--- /dev/null
+++ b/third_party/WebKit/Source/modules/webauth/AuthenticatorAssertionResponse.h
@@ -0,0 +1,51 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef AuthenticatorAssertionResponse_h
+#define AuthenticatorAssertionResponse_h
+
+#include "core/dom/DOMArrayBuffer.h"
+#include "modules/webauth/AuthenticatorResponse.h"
+#include "platform/bindings/ScriptWrappable.h"
+
+namespace blink {
+
+class AuthenticatorAssertionResponse final : public AuthenticatorResponse {
+  DEFINE_WRAPPERTYPEINFO();
+
+ public:
+  static AuthenticatorAssertionResponse* Create(
+      DOMArrayBuffer* client_data_json,
+      DOMArrayBuffer* authenticator_data,
+      DOMArrayBuffer* signature) {
+    return new AuthenticatorAssertionResponse(client_data_json,
+                                              authenticator_data, signature);
+  }
+

[engedy, 2017/07/05 18:51:03]

optional nit: Do we want to supply a user-declared destructor here? I suppose
this depends on the answer to the other question, i.e. whether we are okay with
having it inlined.

[kpaulhamus, 2017/07/12 21:21:46]

Done.

+  DOMArrayBuffer* authenticatorData() const {
+    return authenticator_data_.Get();
+  }

[engedy, 2017/07/05 18:51:04]

nit: Add blank line.

[kpaulhamus, 2017/07/12 21:21:45]

Done.

+  DOMArrayBuffer* signature() const { return signature_.Get(); }
+
+  DEFINE_INLINE_TRACE() {

[engedy, 2017/07/05 18:51:04]

nit: I think this should be DEFINE_INLINE_VIRTUAL_TRACE.

[kpaulhamus, 2017/07/12 21:21:46]

Done.

+    AuthenticatorResponse::Trace(visitor);

[engedy, 2017/07/05 18:51:04]

nit: The GC API Guidelines recommend putting the delegation call at the end of
the trace method. See:
https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/So...

[kpaulhamus, 2017/07/12 21:21:45]

Done.

+    visitor->Trace(authenticator_data_);
+    visitor->Trace(signature_);
+  }
+
+ private:
+  AuthenticatorAssertionResponse(DOMArrayBuffer* client_data_json,
+                                 DOMArrayBuffer* authenticator_data,
+                                 DOMArrayBuffer* signature)
+      : AuthenticatorResponse(client_data_json),
+        authenticator_data_(authenticator_data),
+        signature_(signature) {}
+
+  const Member<DOMArrayBuffer> authenticator_data_;
+  const Member<DOMArrayBuffer> signature_;
+};
+
+}  // namespace blink
+
+#endif  // AuthenticatorAssertionResponse_h