 Chromium Code Reviews
 Chromium Code Reviews Issue 2966523002:
  Blink-layer update to match WebAuthN spec  (Closed)
    
  
    Issue 2966523002:
  Blink-layer update to match WebAuthN spec  (Closed) 
  | Index: third_party/WebKit/Source/modules/webauth/AuthenticatorAttestationResponse.h | 
| diff --git a/third_party/WebKit/Source/modules/webauth/AuthenticatorAttestationResponse.h b/third_party/WebKit/Source/modules/webauth/AuthenticatorAttestationResponse.h | 
| new file mode 100644 | 
| index 0000000000000000000000000000000000000000..a20123d33e751b01f3d00ee54b7183495bbcfe1f | 
| --- /dev/null | 
| +++ b/third_party/WebKit/Source/modules/webauth/AuthenticatorAttestationResponse.h | 
| @@ -0,0 +1,47 @@ | 
| +// Copyright 2016 The Chromium Authors. All rights reserved. | 
| +// Use of this source code is governed by a BSD-style license that can be | 
| +// found in the LICENSE file. | 
| + | 
| +#ifndef AuthenticatorAttestationResponse_h | 
| +#define AuthenticatorAttestationResponse_h | 
| + | 
| +#include "core/dom/DOMArrayBuffer.h" | 
| +#include "modules/webauth/AuthenticatorResponse.h" | 
| +#include "platform/bindings/ScriptWrappable.h" | 
| + | 
| +namespace blink { | 
| + | 
| +class AuthenticatorAttestationResponse final : public AuthenticatorResponse { | 
| + DEFINE_WRAPPERTYPEINFO(); | 
| + | 
| + public: | 
| + static AuthenticatorAttestationResponse* Create( | 
| + DOMArrayBuffer* client_data_json, | 
| + DOMArrayBuffer* attestation_object) { | 
| + return new AuthenticatorAttestationResponse(client_data_json, | 
| + attestation_object); | 
| + } | 
| + | 
| + AuthenticatorAttestationResponse(DOMArrayBuffer* client_data_json, | 
| + DOMArrayBuffer* attestation_object) | 
| + : AuthenticatorResponse(client_data_json), | 
| + attestation_object_(attestation_object) {} | 
| 
Mike West
2017/06/30 08:06:35
Should this constructor be private?
 
kpaulhamus
2017/06/30 10:59:39
Done.
 | 
| + | 
| + virtual ~AuthenticatorAttestationResponse() {} | 
| 
Mike West
2017/06/30 08:06:35
I don't think you need this, since you define an e
 
kpaulhamus
2017/06/30 10:59:39
Done.
 | 
| + | 
| + DOMArrayBuffer* attestationObject() const { | 
| + return attestation_object_.Get(); | 
| + } | 
| + | 
| + DEFINE_INLINE_TRACE() { | 
| + AuthenticatorResponse::Trace(visitor); | 
| + visitor->Trace(attestation_object_); | 
| + } | 
| + | 
| + private: | 
| + const Member<DOMArrayBuffer> attestation_object_; | 
| +}; | 
| + | 
| +} // namespace blink | 
| + | 
| +#endif // AuthenticatorAttestationResponse_h |