third_party/WebKit/Source/modules/webauth/WebAuthentication.idl - Issue 2966523002: Blink-layer update to match WebAuthN spec

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/webauth/WebAuthentication.idl

Issue 2966523002: Blink-layer update to match WebAuthN spec (Closed)

Patch Set: Modify browser-side impl and unittests. Address mkwst comments. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/modules/webauth/WebAuthentication.cpp ('K') | « third_party/WebKit/Source/modules/webauth/WebAuthentication.cpp ('k') | third_party/WebKit/public/platform/modules/webauth/authenticator.mojom » ('j') | third_party/WebKit/public/platform/modules/webauth/authenticator.mojom » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://w3c.github.io/webauthn/#webauthentication	5 // https://w3c.github.io/webauthn/#webauthentication
	engedy 2017/07/05 18:51:09 nit: Note that this link is no longer valid. Maybe nit: Note that this link is no longer valid. Maybe remove, add TODO, or add new link to CM API? kpaulhamus 2017/07/12 21:21:49 Done. Show quoted text On 2017/07/05 18:51:09, engedy wrote: > nit: Note that this link is no longer valid. Maybe remove, add TODO, or add new > link to CM API? Done.
6	6

7 [	7 [

8 RuntimeEnabled=WebAuth,	8 RuntimeEnabled=WebAuth,

9 SecureContext	9 SecureContext

10 ] interface WebAuthentication {	10 ] interface WebAuthentication {

11 [CallWith=ScriptState] Promise<sequence<ScopedCredentialInfo>> makeCredentia l(RelyingPartyAccount accountInformation, sequence<ScopedCredentialParameters> c ryptoParameters, BufferSource attestationChallenge, optional ScopedCredentialOpt ions options);	11 [CallWith=ScriptState] Promise<sequence<AuthenticatorAttestationResponse>> m akeCredential(MakeCredentialOptions publicKey);
	engedy 2017/07/05 18:51:08 nit: Maybe I'm missing something, but the new spec nit: Maybe I'm missing something, but the new spec does not seem to support returning multiple results. WDYT about removing the sequence<...> references here already in this CL? kpaulhamus 2017/07/12 21:21:49 Sure Show quoted text On 2017/07/05 18:51:08, engedy wrote: > nit: Maybe I'm missing something, but the new spec does not seem to support > returning multiple results. WDYT about removing the sequence<...> references > here already in this CL? Sure
12 [CallWith=ScriptState] Promise<sequence<WebAuthnAssertion>> getAssertion(Buf ferSource assertionChallenge, optional AuthenticationAssertionOptions options);	12 [CallWith=ScriptState] Promise<sequence<AuthenticatorAssertionResponse>> get Assertion(PublicKeyCredentialRequestOptions publicKey);

13 };	13 };

OLD	NEW