Blink-layer update to match WebAuthN spec

third_party/WebKit/Source/modules/webauth/AuthenticatorResponse.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef AuthenticatorResponse_h
+#define AuthenticatorResponse_h
+
+#include "core/dom/DOMArrayBuffer.h"
+#include "platform/bindings/ScriptWrappable.h"

[engedy, 2017/07/05 18:51:05]

Please add `#include "platform/heap/Handle.h"` in all files using
GarbageCollected<> and friends.

[kpaulhamus, 2017/07/12 21:21:46]

Done.

+
+namespace blink {
+
+class AuthenticatorResponse

[engedy, 2017/07/05 18:51:04]

optional nit: I wonder if most of these classes should be marked MODULES_EXPORT?
@Mike, @Daniel?

[engedy, 2017/07/10 14:32:36]

Short answer: yes.

[kpaulhamus, 2017/07/12 21:21:46]

Done.

+    : public GarbageCollectedFinalized<AuthenticatorResponse>,
+      public ScriptWrappable {
+  DEFINE_WRAPPERTYPEINFO();
+
+ public:
+  static AuthenticatorResponse* Create(DOMArrayBuffer* client_data_json) {
+    return new AuthenticatorResponse(client_data_json);
+  }
+
+  virtual ~AuthenticatorResponse() {}
+
+  DOMArrayBuffer* clientDataJSON() const { return client_data_json_.Get(); }
+
+  DEFINE_INLINE_VIRTUAL_TRACE() { visitor->Trace(client_data_json_); }
+
+ protected:
+  AuthenticatorResponse(DOMArrayBuffer* client_data_json)

[engedy, 2017/07/05 18:51:04]

nit: explicit

[engedy, 2017/07/05 18:51:04]

optional nit: In Chromium-land these constructor/destructors would be deemed
complex enough not to be inlined. @Mike, @Daniel, I wonder if the same applies
in Blink-land? If we decide to make them out-of-line (in a .cpp file), that
would apply to a couple classes in this CL.

[engedy, 2017/07/10 14:32:36]

I talked to jochen@, and he tells me these should not be inline. Normally we
have a clang plugin [1] to check this, but I'm told it's not run for WebKit
code.

[1]:
https://www.chromium.org/developers/coding-style/chromium-style-checker-error...

[kpaulhamus, 2017/07/12 21:21:46]

K, I made impl files for AuthenticatorResponse,
AuthenticatorAttestationResponse, AuthenticatorAssertionResponse, and
PublicKeyKeyCredential. Take a look and see if that's what you had in mind.

[kpaulhamus, 2017/07/12 21:21:46]

Done.

[engedy, 2017/07/13 11:33:53]

Yep, that's exactly it, thanks!

+      : client_data_json_(client_data_json) {}
+
+ private:
+  const Member<DOMArrayBuffer> client_data_json_;
+};
+
+}  // namespace blink
+
+#endif  // AuthenticatorResponse_h