Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: third_party/WebKit/Source/modules/webauth/AuthenticatorAttestationResponse.h

Issue 2966523002: Blink-layer update to match WebAuthN spec (Closed)
Patch Set: Modify browser-side impl and unittests. Address mkwst comments. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef AuthenticatorAttestationResponse_h
6 #define AuthenticatorAttestationResponse_h
7
8 #include "core/dom/DOMArrayBuffer.h"
9 #include "modules/webauth/AuthenticatorResponse.h"
10 #include "platform/bindings/ScriptWrappable.h"
11
12 namespace blink {
13
14 class AuthenticatorAttestationResponse final : public AuthenticatorResponse {
15 DEFINE_WRAPPERTYPEINFO();
16
17 public:
18 static AuthenticatorAttestationResponse* Create(
19 DOMArrayBuffer* client_data_json,
20 DOMArrayBuffer* attestation_object) {
21 return new AuthenticatorAttestationResponse(client_data_json,
22 attestation_object);
23 }
24
25 AuthenticatorAttestationResponse(DOMArrayBuffer* client_data_json,
engedy 2017/07/05 18:51:04 nit: Make constructor private if possible.
kpaulhamus 2017/07/12 21:21:46 Done.
26 DOMArrayBuffer* attestation_object)
27 : AuthenticatorResponse(client_data_json),
28 attestation_object_(attestation_object) {}
29
30 virtual ~AuthenticatorAttestationResponse() {}
vasilii 2017/07/05 14:36:13 override
kpaulhamus 2017/07/12 21:21:46 Actually don't think it's needed, took it out.
31
32 DOMArrayBuffer* attestationObject() const {
33 return attestation_object_.Get();
34 }
35
36 DEFINE_INLINE_TRACE() {
37 AuthenticatorResponse::Trace(visitor);
engedy 2017/07/05 18:51:04 nit: Put delegation call at the end here, as well
kpaulhamus 2017/07/12 21:21:46 Done.
38 visitor->Trace(attestation_object_);
39 }
40
41 private:
42 const Member<DOMArrayBuffer> attestation_object_;
43 };
44
45 } // namespace blink
46
47 #endif // AuthenticatorAttestationResponse_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698