chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_impl_win.h - Issue 2966453002: Chrome Cleaner UI: Add logs upload permission checkbox to the dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_impl_win.h

Issue 2966453002: Chrome Cleaner UI: Add logs upload permission checkbox to the dialog (Closed)

Patch Set: Addressed comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_win_unittest.cc ('K') | « chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_win_unittest.cc ('k') | chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_impl_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_impl_win.h

diff --git a/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_impl_win.h b/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_impl_win.h

index 64b1ea812b56b16be017339fc883bb17765256ad..8c87c4f13cb6e5de3ad19c4f64eda31318204fc3 100644

--- a/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_impl_win.h

+++ b/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_impl_win.h

@@ -27,10 +27,12 @@ class ChromeCleanerDialogControllerImpl

// ChromeCleanerDialogController overrides.

void DialogShown() override;

- void Accept() override;

+ void Accept(bool logs_enabled) override;

void Cancel() override;

void Close() override;

- void DetailsButtonClicked() override;

+ void DetailsButtonClicked(bool logs_enabled) override;

+ void SetLogsEnabled(bool logs_enabled) override;

+ bool LogsEnabled() override;

// ChromeCleanerController::Observer overrides.

void OnIdle(ChromeCleanerController::IdleReason idle_reason) override;