Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3385)

Unified Diff: chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_win.h

Issue 2966453002: Chrome Cleaner UI: Add logs upload permission checkbox to the dialog (Closed)
Patch Set: More comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_win.h
diff --git a/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_win.h b/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_win.h
index 40b4fc566d6f757e84039ea23b218d11baa40d39..eb1d375ef5a7cffe18892e014b62d6ff662952d9 100644
--- a/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_win.h
+++ b/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_win.h
@@ -23,7 +23,7 @@ class ChromeCleanerDialogController {
// Called by the Cleaner dialog when user accepts the prompt. Once |Accept()|
// has been called, the controller will eventually delete itself and no member
// functions should be called after that.
- virtual void Accept() = 0;
+ virtual void Accept(bool logs_enabled) = 0;
// Called by the Cleaner dialog when the dialog is closed via the cancel
// button. Once |Cancel()| has been called, the controller will eventually
// delete itself and no member functions should be called after that.
@@ -38,7 +38,14 @@ class ChromeCleanerDialogController {
// close. After a call to |DetailsButtonClicked()|, the controller will
// eventually delete itself and no member functions should be called after
// that.
- virtual void DetailsButtonClicked() = 0;
+ virtual void DetailsButtonClicked(bool logs_enabled) = 0;
+
+ // To be called by the dialog when the user changes the state of the logs
+ // upload permission checkbox.
+ virtual void SetLogsEnabled(bool logs_enabled) = 0;
+ // Returns whether logs upload is currently enabled. Used to set the dialog's
+ // default permission checkbox state.
+ virtual bool LogsEnabled() = 0;
protected:
virtual ~ChromeCleanerDialogController() {}

Powered by Google App Engine
This is Rietveld 408576698