Issue 2966373002: Fix a telemetry test. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(835)

My Issues | Starred Open | Closed | All

Issue 2966373002: Fix a telemetry test. (Closed)

Created:
3 years, 5 months ago by devoncarew

Modified:
3 years, 5 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix a telemetry test. BUG= Committed: https://github.com/dart-lang/sdk/commit/ca8d646ce134e4baa6d655ef29e91932c3a69d02

Patch Set 1 #

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	pkg/telemetry/test/crash_reporting_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

devoncarew

Fix a telemetry test. Without the mock analytics object enabled, it would never send the ...

3 years, 5 months ago (2017-07-06 07:01:48 UTC) #2

devoncarew

Committed patchset #1 (id:1) manually as ca8d646ce134e4baa6d655ef29e91932c3a69d02 (presubmit successful).

3 years, 5 months ago (2017-07-06 07:02:19 UTC) #5

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Powered by Google App Engine

This is Rietveld 408576698