Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2966313002: Remove ExecutableElement.localVariables altogether. (Closed)

Created:
3 years, 5 months ago by scheglov
Modified:
3 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove ExecutableElement.localVariables altogether. It is not used in analyzer or analysis_server, and in packages in internal codebase. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/7ed5e1c433c285785413dfffd53220b40d45450b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -273 lines) Patch
M pkg/analyzer/lib/dart/element/element.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/builder.dart View 12 chunks +12 lines, -12 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 6 chunks +10 lines, -54 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/handle.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/member.dart View 2 chunks +0 lines, -11 lines 0 comments Download
M pkg/analyzer/lib/src/fasta/mock_element.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/declaration_resolver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 3 chunks +1 line, -42 lines 0 comments Download
M pkg/analyzer/test/dart/element/builder_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 2 chunks +0 lines, -139 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 5 months ago (2017-07-05 23:46:48 UTC) #1
Brian Wilkerson
lgtm
3 years, 5 months ago (2017-07-05 23:52:10 UTC) #2
scheglov
3 years, 5 months ago (2017-07-05 23:59:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7ed5e1c433c285785413dfffd53220b40d45450b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698