Fixing signed in message and disconnect/reconnect case.

remoting/ios/app/remoting_view_controller.mm

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)
 #error "This file requires ARC support."
 #endif
 
 #import "remoting/ios/app/remoting_view_controller.h"
 
@@ skipping 18 matching lines @@
 
 #include "base/strings/sys_string_conversions.h"
 #include "remoting/base/oauth_token_getter.h"
 #include "remoting/client/connect_to_host_info.h"
 
 static CGFloat kHostInset = 5.f;
 
 @interface RemotingViewController ()<HostCollectionViewControllerDelegate,
                                      UIViewControllerAnimatedTransitioning,
                                      UIViewControllerTransitioningDelegate> {
-  bool _isAuthenticated;
+  BOOL _isAuthenticated;
+  BOOL _showSignedInAccount;
   MDCDialogTransitionController* _dialogTransitionController;
   MDCAppBar* _appBar;
   HostCollectionViewController* _collectionViewController;
   HostFetchingViewController* _fetchingViewController;
   HostSetupViewController* _setupViewController;
   RemotingService* _remotingService;
 }
 @end
 
 // TODO(nicholss): Localize this file.
 // TODO(nicholss): This file is not finished with integration, the app flow is
 // still pending development.
 
 @implementation RemotingViewController
 
 - (instancetype)init {
   _isAuthenticated = NO;
+  _showSignedInAccount = YES;
   UICollectionViewFlowLayout* layout =
       [[MDCCollectionViewFlowLayout alloc] init];
   layout.minimumInteritemSpacing = 0;
   CGFloat sectionInset = kHostInset * 2.f;
   [layout setSectionInset:UIEdgeInsetsMake(sectionInset, sectionInset,
                                            sectionInset, sectionInset)];
   self = [super init];
   if (self) {
     _remotingService = RemotingService.instance;
 
@@ skipping 73 matching lines @@
          selector:@selector(hostListStateDidChangeNotification:)
              name:kHostListStateDidChange
            object:nil];
   [[NSNotificationCenter defaultCenter]
       addObserver:self
          selector:@selector(userDidUpdateNotification:)
              name:kUserDidUpdate
            object:nil];
 }
 
-- (void)viewWillAppear:(BOOL)animated {
-  [super viewWillAppear:animated];
-
-  [self nowAuthenticated:_remotingService.authentication.user.isAuthenticated];
-  if (_isAuthenticated) {
-    [_remotingService requestHostListFetch];
-  }
-  [self presentStatus];
-}
-
 - (void)viewDidAppear:(BOOL)animated {
   [super viewDidAppear:animated];
-  if (!_isAuthenticated) {
+  if (!_remotingService.authentication.user.isAuthenticated) {
     [AppDelegate.instance presentSignInFlow];
     MDCSnackbarMessage* message = [[MDCSnackbarMessage alloc] init];
     message.text = @"Please login.";
     [MDCSnackbarManager showMessage:message];
   }
 }
 
 - (UIStatusBarStyle)preferredStatusBarStyle {
   return UIStatusBarStyleLightContent;
 }
 
 #pragma mark - Remoting Service Notifications
 
 - (void)hostListStateDidChangeNotification:(NSNotification*)notification {
   [self refreshContent];
 }
 
 - (void)userDidUpdateNotification:(NSNotification*)notification {
-  [self nowAuthenticated:_remotingService.authentication.user.isAuthenticated];
+  [[NSOperationQueue mainQueue] addOperationWithBlock:^{
+    [self
+        nowAuthenticated:_remotingService.authentication.user.isAuthenticated];
+  }];
 }
 
 #pragma mark - RemotingAuthenticationDelegate
 
 - (void)nowAuthenticated:(BOOL)authenticated {
+  _isAuthenticated = authenticated;
   if (authenticated) {
-    MDCSnackbarMessage* message = [[MDCSnackbarMessage alloc] init];
-    message.text = @"Logged In!";
-    [MDCSnackbarManager showMessage:message];
+    _showSignedInAccount = YES;
+    [self presentStatus];
   } else {
     MDCSnackbarMessage* message = [[MDCSnackbarMessage alloc] init];
-    message.text = @"Not logged in.";
+    message.text = @"Please sign-in.";
     [MDCSnackbarManager showMessage:message];
   }
-  _isAuthenticated = authenticated;
   [self refreshContent];
 }
 
 #pragma mark - HostCollectionViewControllerDelegate
 
 - (void)didSelectCell:(HostCollectionViewCell*)cell
            completion:(void (^)())completionBlock {
   if (![cell.hostInfo isOnline]) {
     MDCSnackbarMessage* message = [[MDCSnackbarMessage alloc] init];
     message.text = @"Host is offline.";
@@ skipping 54 matching lines @@
   // controls that.
   [_remotingService requestHostListFetch];
 }
 
 - (void)didSelectMenu {
   [AppDelegate.instance showMenuAnimated:YES];
 }
 
 - (void)presentStatus {
   MDCSnackbarMessage* message = [[MDCSnackbarMessage alloc] init];
-  if (_isAuthenticated) {
+  if (_isAuthenticated && _showSignedInAccount) {
+    _showSignedInAccount = NO;
     message.text = [NSString
         stringWithFormat:@"Currently signed in as %@.",
                          _remotingService.authentication.user.userEmail];
     [MDCSnackbarManager showMessage:message];
   }
 }
 
 - (void)refreshContent {
   if (_remotingService.hostListState == HostListStateNotFetched) {
     self.contentViewController = nil;
@@ skipping 15 matching lines @@
     self.contentViewController = _collectionViewController;
   } else {
     self.contentViewController = _setupViewController;
     self.headerViewController.headerView.trackingScrollView =
         _setupViewController.collectionView;
   }
   self.contentViewController.view.frame = self.view.bounds;
 }
 
 @end