Omnibox UI Experiments: Strip trivial subdomains

components/omnibox/browser/autocomplete_match_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/omnibox/browser/autocomplete_match.h"
 
 #include <stddef.h>
 
 #include "base/macros.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 93 matching lines @@
   // Test an arbitrary complicated case.
   EXPECT_EQ("0,2," "1,0," "2,1," "4,3," "5,7," "6,3," "7,7," "15,1," "17,0",
       AutocompleteMatch::ClassificationsToString(
           AutocompleteMatch::MergeClassifications(
               AutocompleteMatch::ClassificationsFromString(
                   "0,0," "2,1," "4,3," "7,7," "10,6," "15,0"),
               AutocompleteMatch::ClassificationsFromString(
                   "0,2," "1,0," "5,7," "6,1," "17,0"))));
 }
 
 TEST(AutocompleteMatchTest, FormatUrlForSuggestionDisplay) {

[Peter Kasting, 2017/07/06 06:01:21]

Nit: Might want a comment somewhere in this function to the effect that you
don't need in-depth tests for the functionality of each formatting flag because
those happen in <cross-reference location>; you just need to check that flipping
the right feature flags does in fact toggle the behavior at this level.

[tommycli, 2017/07/06 16:25:46]

Done.

   struct FormatUrlTestData {
     const std::string url;
     bool trim_scheme;
     const std::string expected_result;
 
     void Validate() {
       SCOPED_TRACE(testing::Message()
                    << " url= " << url << " trim_scheme=" << trim_scheme
                    << " expected_result=" << expected_result);
       auto format_types = AutocompleteMatch::GetFormatTypes(trim_scheme);
       EXPECT_EQ(expected_result,
                 base::UTF16ToASCII(url_formatter::FormatUrl(
                     GURL(url), format_types, net::UnescapeRule::SPACES, nullptr,
                     nullptr, nullptr)));
     };
   };
 
-  // Sanity check that the trim_strings parameter works.
   FormatUrlTestData normal_cases[] = {
+      // Test trim_scheme parameter without any feature flags.
       {"http://google.com", true, "google.com"},
       {"https://google.com", true, "https://google.com"},
       {"http://google.com", false, "http://google.com"},
       {"https://google.com", false, "https://google.com"},
-  };
+
+      // Verify that trivial subdomains are preserved in the normal case.
+      {"http://www.google.com", false, "http://www.google.com"}};
   for (FormatUrlTestData& test_case : normal_cases)
     test_case.Validate();
 
-  // Test the hide-scheme feature flag.
+  // Test the hide-scheme feature flag with the trim_scheme paramater.
   std::unique_ptr<base::test::ScopedFeatureList> feature_list(
       new base::test::ScopedFeatureList);
   feature_list->InitAndEnableFeature(
       omnibox::kUIExperimentHideSuggestionUrlScheme);
 
   FormatUrlTestData omit_scheme_cases[] = {
       {"http://google.com", true, "google.com"},
       {"https://google.com", true, "google.com"},
       {"http://google.com", false, "http://google.com"},
       {"https://google.com", false, "https://google.com"},
   };
   for (FormatUrlTestData& test_case : omit_scheme_cases)
     test_case.Validate();
+
+  // Test the trim trivial subdomains feature flag.
+  feature_list.reset(new base::test::ScopedFeatureList);
+  feature_list->InitAndEnableFeature(
+      omnibox::kUIExperimentHideSuggestionUrlTrivialSubdomains);
+
+  FormatUrlTestData trim_trivial_subdomains_case = {"http://www.m.google.com",
+                                                    false, "http://google.com"};
+  trim_trivial_subdomains_case.Validate();
 }
 
 TEST(AutocompleteMatchTest, SupportsDeletion) {
   // A non-deletable match with no duplicates.
   AutocompleteMatch m(NULL, 0, false,
                       AutocompleteMatchType::URL_WHAT_YOU_TYPED);
   EXPECT_FALSE(m.SupportsDeletion());
 
   // A deletable match with no duplicates.
   AutocompleteMatch m1(NULL, 0, true,
@@ skipping 75 matching lines @@
     m1.destination_url = GURL(cases[i].url1);
     m1.ComputeStrippedDestinationURL(input, nullptr);
     AutocompleteMatch m2(nullptr, 100, false,
                          AutocompleteMatchType::URL_WHAT_YOU_TYPED);
     m2.destination_url = GURL(cases[i].url2);
     m2.ComputeStrippedDestinationURL(input, nullptr);
     EXPECT_EQ(cases[i].expected_duplicate,
               AutocompleteMatch::DestinationsEqual(m1, m2));
   }
 }