[cr-action-menu] Use clientWidth for rtl flipping.

ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.js

Index: ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.js
diff --git a/ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.js b/ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.js
index 33414bd3c156e6aed1d45b49c4e086cb79aa8fdb..d737a42c76682aa51815eda6e42f144e174714b4 100644
--- a/ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.js
+++ b/ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.js
@@ -89,10 +89,10 @@ function getDefaultShowConfig() {
     width: 0,
     anchorAlignmentX: AnchorAlignment.AFTER_START,
     anchorAlignmentY: AnchorAlignment.AFTER_START,
-    minX: doc.scrollLeft,
-    minY: doc.scrollTop,
-    maxX: doc.scrollLeft + window.innerWidth,
-    maxY: doc.scrollTop + window.innerHeight,
+    minX: 0,
+    minY: 0,
+    maxX: 0,
+    maxY: 0,
   };
 }
 
@@ -253,22 +253,8 @@ Polymer({
     // accurate for where the menu should be shown.
     this.anchorElement_.scrollIntoViewIfNeeded();
 
-    // Save the scroll position that ensures the anchor element is onscreen.
-    var doc = document.scrollingElement;
-    var scrollLeft = doc.scrollLeft;
-    var scrollTop = doc.scrollTop;
-
-    // Reset position so that layout isn't affected by the previous position,
-    // and so that the dialog is positioned at the top-start corner of the
-    // document.
-    this.resetStyle_();
-
-    // Show the dialog which will focus the top-start of the body. This makes
-    // the client rect calculation relative to the top-start of the body.
-    this.showModal();
-
     var rect = this.anchorElement_.getBoundingClientRect();
-    this.positionDialog_(/** @type {ShowConfig} */ (Object.assign(
+    this.showAtPosition(/** @type {ShowConfig} */ (Object.assign(
         {
           top: rect.top,
           left: rect.left,
@@ -276,18 +262,8 @@ Polymer({
           width: rect.width,
           // Default to anchoring towards the left.
           anchorAlignmentX: AnchorAlignment.BEFORE_END,
-          minX: scrollLeft,
-          minY: scrollTop,
-          maxX: scrollLeft + window.innerWidth,
-          maxY: scrollTop + window.innerHeight,
         },
         opt_config)));
-
-    // Restore the scroll position.
-    doc.scrollTop = scrollTop;
-    doc.scrollLeft = scrollLeft;
-
-    this.addCloseListeners_();
   },
 
   /**
@@ -295,7 +271,8 @@ Polymer({
    * specified as an X and Y alignment which represents a point in the anchor
    * where the menu will align to, which can have the menu either before or
    * after the given point in each axis. Center alignment places the center of
-   * the menu in line with the center of the anchor.
+   * the menu in line with the center of the anchor. Coordinates are relative to
+   * the top-left of the viewport.
    *
    *            y-start
    *         _____________
@@ -317,9 +294,32 @@ Polymer({
    * @param {!ShowConfig} config
    */
   showAtPosition: function(config) {
+    // Save the scroll position of the viewport.
+    var doc = document.scrollingElement;
+    var scrollLeft = doc.scrollLeft;
+    var scrollTop = doc.scrollTop;
+
+    // Reset position so that layout isn't affected by the previous position,
+    // and so that the dialog is positioned at the top-start corner of the
+    // document.
     this.resetStyle_();
     this.showModal();
-    this.positionDialog_(config);
+
+    config.top += scrollTop;
+    config.left += scrollLeft;
+
+    this.positionDialog_(/** @type {ShowConfig} */ (Object.assign(
+        {
+          minX: scrollLeft,
+          minY: scrollTop,
+          maxX: scrollLeft + doc.clientWidth,
+          maxY: scrollTop + doc.clientHeight,
+        },
+        config)));
+
+    // Restore the scroll position.
+    doc.scrollTop = scrollTop;
+    doc.scrollLeft = scrollLeft;
     this.addCloseListeners_();
   },
 
@@ -331,6 +331,8 @@ Polymer({
   },
 
   /**
+   * Position the dialog using the coordinates in config. Coordinates are
+   * relative to the top-left of the viewport when scrolled to (0, 0).
    * @param {!ShowConfig} config
    * @private
    */
@@ -351,7 +353,8 @@ Polymer({
         left, right, this.offsetWidth, c.anchorAlignmentX, c.minX, c.maxX);
 
     if (rtl) {
-      var menuRight = document.body.scrollWidth - menuLeft - this.offsetWidth;
+      var menuRight =
+          document.scrollingElement.clientWidth - menuLeft - this.offsetWidth;
       this.style.right = menuRight + 'px';
     } else {
       this.style.left = menuLeft + 'px';