Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 296613002: Mojo: Mojom: The handle type can/should be a NAME not an identifier. (Closed)

Created:
6 years, 7 months ago by viettrungluu
Modified:
6 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Mojo: Mojom: The handle type can/should be a NAME not an identifier. Duh. (Ironically, this will lead to a less-helpful error message if you try "handle<foo.bar>", but in the same way as "handle<123>" doesn't give a super-helpful error message.) R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271585

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mojo/public/tools/bindings/pylib/mojom/parse/parser.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
viettrungluu
6 years, 7 months ago (2014-05-20 00:10:54 UTC) #1
darin (slow to review)
LGTM
6 years, 7 months ago (2014-05-20 00:11:50 UTC) #2
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 7 months ago (2014-05-20 00:18:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/296613002/1
6 years, 7 months ago (2014-05-20 00:19:07 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 03:47:48 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 06:24:53 UTC) #6
Message was sent while issue was closed.
Change committed as 271585

Powered by Google App Engine
This is Rietveld 408576698