chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileBridge.java - Issue 2966103002: [Payments] Show admin area complete names on PR form.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileBridge.java

Issue 2966103002: [Payments] Show admin area complete names on PR form. (Closed)

Patch Set: Small Changes. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java ('k') | chrome/browser/autofill/android/personal_data_manager_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileBridge.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileBridge.java

index a5bc8eb534f070ba275cd5e72b3c0951e2d54524..e4a316eb774244b372201edb7e6dcb460027d30a 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileBridge.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileBridge.java

@@ -101,12 +101,12 @@ public class AutofillProfileBridge {

}

/** @return The list of admin areas sorted by their localized display names. */

- public static List<DropdownKeyValue> getAdminAreaDropdownList(String[] keys) {

+ public static List<DropdownKeyValue> getAdminAreaDropdownList(

+ String[] adminAreaCodes, String[] adminAreaNames) {

List<DropdownKeyValue> adminAreas = new ArrayList<>();

- for (int i = 0; i < keys.length; ++i) {

- // TODO (parastoog): show names, save keys. @crbug.com/691643

- adminAreas.add(new DropdownKeyValue(keys[i], keys[i]));

+ for (int i = 0; i < adminAreaCodes.length; ++i) {

+ adminAreas.add(new DropdownKeyValue(adminAreaCodes[i], adminAreaNames[i]));

}

final Collator collator = Collator.getInstance(Locale.getDefault());