Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: third_party/libaddressinput/chromium/chrome_address_validator.cc

Issue 2966103002: [Payments] Show admin area complete names on PR form. (Closed)
Patch Set: Keys to names Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/libaddressinput/chromium/chrome_address_validator.cc
diff --git a/third_party/libaddressinput/chromium/chrome_address_validator.cc b/third_party/libaddressinput/chromium/chrome_address_validator.cc
index f76bcbd15fda6b170d7941f5f63842d5ea49afff..d923e01be919be531a3b6fd2a7be4205de975b96 100644
--- a/third_party/libaddressinput/chromium/chrome_address_validator.cc
+++ b/third_party/libaddressinput/chromium/chrome_address_validator.cc
@@ -60,18 +60,24 @@ void AddressValidator::LoadRules(const std::string& region_code) {
supplier_->LoadRules(region_code, *rules_loaded_);
}
-std::vector<std::string> AddressValidator::GetRegionSubKeys(
- const std::string& region_code) {
+std::vector<std::pair<std::string, std::string>>
+AddressValidator::GetRegionSubKeys(const std::string& region_code) {
+ std::vector<std::pair<std::string, std::string>> subkeys_codes_names;
if (!AreRulesLoadedForRegion(region_code))
- return std::vector<std::string>();
+ return subkeys_codes_names;
auto rules = supplier_->GetRulesForRegion(region_code);
- auto rule_iterator = rules.find("data/" + region_code);
- if (rule_iterator == rules.end() || !rule_iterator->second)
- return std::vector<std::string>();
+ std::string code_prefix = "data/" + region_code + "/";
+ size_t code_prefix_size = code_prefix.size();
Mathieu 2017/07/05 16:07:15 nit: code_prefix_size = region_code.size() + 6;
Parastoo 2017/07/07 15:53:23 Done.
- return rule_iterator->second->GetSubKeys();
+ for (auto r : rules) {
+ if (r.first.size() <= code_prefix_size)
Mathieu 2017/07/05 16:07:15 Could we get in a situation where the key is data/
Parastoo 2017/07/07 15:53:23 Done.
+ continue;
+ subkeys_codes_names.push_back(
+ std::make_pair(r.first.substr(code_prefix_size), r.second->GetName()));
+ }
+ return subkeys_codes_names;
}
AddressValidator::Status AddressValidator::ValidateAddress(

Powered by Google App Engine
This is Rietveld 408576698