components/webdata/common/web_database_migration_unittest.cc - Issue 296593003: Make various string_util functions take StringPieces instead of char[].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/webdata/common/web_database_migration_unittest.cc

Issue 296593003: Make various string_util functions take StringPieces instead of char[]. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Resync Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cloud_devices/common/cloud_devices_urls.cc ('k') | extensions/common/permissions/socket_permission_entry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/webdata/common/web_database_migration_unittest.cc

diff --git a/components/webdata/common/web_database_migration_unittest.cc b/components/webdata/common/web_database_migration_unittest.cc

index b0925bc4d0074214756a3db3f60c58f028e608c6..aa3d0dd65a40023b66b282801a99afcdab169ea8 100644

--- a/components/webdata/common/web_database_migration_unittest.cc

+++ b/components/webdata/common/web_database_migration_unittest.cc

@@ -157,10 +157,9 @@ void CheckNoBackupData(const sql::Connection& connection,

}

std::string RemoveQuotes(const std::string& has_quotes) {

- // SQLite quotes: http://www.sqlite.org/lang_keywords.html

- static const char kQuotes[] = "\"[]`";

std::string no_quotes;

- base::RemoveChars(has_quotes, kQuotes, &no_quotes);

+ // SQLite quotes: http://www.sqlite.org/lang_keywords.html

+ base::RemoveChars(has_quotes, "\"[]`", &no_quotes);

return no_quotes;

}

« no previous file with comments | « components/cloud_devices/common/cloud_devices_urls.cc ('k') | extensions/common/permissions/socket_permission_entry.cc » ('j') | no next file with comments »