chrome/browser/renderer_context_menu/render_view_context_menu.cc - Issue 296593003: Make various string_util functions take StringPieces instead of char[].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_context_menu/render_view_context_menu.cc

Issue 296593003: Make various string_util functions take StringPieces instead of char[]. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Resync Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/profile_resetter/resettable_settings_snapshot.cc ('k') | chrome/browser/safe_browsing/safe_browsing_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_context_menu/render_view_context_menu.cc

diff --git a/chrome/browser/renderer_context_menu/render_view_context_menu.cc b/chrome/browser/renderer_context_menu/render_view_context_menu.cc

index be70702d0733b4fcc26956d4e9cad34f47964643..2e67237df996ed1f93f4c1b9fc8771add5c1a480 100644

--- a/chrome/browser/renderer_context_menu/render_view_context_menu.cc

+++ b/chrome/browser/renderer_context_menu/render_view_context_menu.cc

@@ -372,8 +372,8 @@ void AddCustomItemsToMenu(const std::vector<content::MenuItem>& items,

// Helper function to escape "&" as "&&".

void EscapeAmpersands(base::string16* text) {

- const base::char16 ampersand[] = {'&', 0};

- base::ReplaceChars(*text, ampersand, base::ASCIIToUTF16("&&"), text);

+ base::ReplaceChars(*text, base::ASCIIToUTF16("&"), base::ASCIIToUTF16("&&"),

+ text);

}

} // namespace