chrome/browser/errorpage_browsertest.cc - Issue 296593003: Make various string_util functions take StringPieces instead of char[].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/errorpage_browsertest.cc

Issue 296593003: Make various string_util functions take StringPieces instead of char[]. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/drive/drive_api_util.cc ('k') | chrome/browser/guest_view/ad_view/ad_view_guest.cc » ('j') | chrome/browser/guest_view/ad_view/ad_view_guest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/errorpage_browsertest.cc

diff --git a/chrome/browser/errorpage_browsertest.cc b/chrome/browser/errorpage_browsertest.cc

index c23c7d04d8fa770c9fc1d2a2063e10a9e7158aca..025492f300e95059a351698a9980cdcda2789854 100644

--- a/chrome/browser/errorpage_browsertest.cc

+++ b/chrome/browser/errorpage_browsertest.cc

@@ -89,8 +89,9 @@ bool WARN_UNUSED_RESULT IsDisplayingNetError(Browser* browser,

net::Error error_code) {

// Get the error as a string, and remove the leading "net::", which is not

// included on error pages.

- std::string error_string = net::ErrorToString(error_code);

- base::RemoveChars(error_string, "net:", &error_string);

+ std::string error_string(net::ErrorToString(error_code));

+ DCHECK(StartsWithASCII(error_string, "net::", true));

+ error_string.erase(0, 5);

return IsDisplayingText(browser, error_string);

}