Make various string_util functions take StringPieces instead of char[].

components/autofill/core/browser/validation.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/validation.h"
 
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_piece.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "components/autofill/core/browser/autofill_regexes.h"
 #include "components/autofill/core/browser/credit_card.h"
 #include "components/autofill/core/browser/state_names.h"
 
-using base::StringPiece16;
-
-namespace {
-
-// The separator characters for SSNs.
-const base::char16 kSSNSeparators[] = {' ', '-', 0};
-
-}  // namespace
 
 namespace autofill {
 
 bool IsValidCreditCardExpirationDate(const base::string16& year,
                                      const base::string16& month,
                                      const base::Time& now) {
   base::string16 year_cleaned, month_cleaned;
   base::TrimWhitespace(year, base::TRIM_ALL, &year_cleaned);
   base::TrimWhitespace(month, base::TRIM_ALL, &month_cleaned);
   if (year_cleaned.length() != 4)
@@ skipping 115 matching lines @@
          !state_names::GetNameForAbbreviation(text).empty();
 }
 
 bool IsValidZip(const base::string16& text) {
   const base::string16 kZipPattern = base::ASCIIToUTF16("^\\d{5}(-\\d{4})?$");
   return MatchesPattern(text, kZipPattern);
 }
 
 bool IsSSN(const base::string16& text) {
   base::string16 number_string;
-  base::RemoveChars(text, kSSNSeparators, &number_string);
+  base::RemoveChars(text, base::ASCIIToUTF16("- "), &number_string);
 
   // A SSN is of the form AAA-GG-SSSS (A = area number, G = group number, S =
   // serial number). The validation we do here is simply checking if the area,
   // group, and serial numbers are valid.
   //
   // Historically, the area number was assigned per state, with the group number
   // ascending in an alternating even/odd sequence. With that scheme it was
   // possible to check for validity by referencing a table that had the highest
   // group number assigned for a given area number. (This was something that
   // Chromium never did though, because the "high group" values were constantly
   // changing.)
   //
   // However, starting on 25 June 2011 the SSA began issuing SSNs randomly from
   // all areas and groups. Group numbers and serial numbers of zero remain
   // invalid, and areas 000, 666, and 900-999 remain invalid.
   //
   // References for current practices:
   //   http://www.socialsecurity.gov/employer/randomization.html
   //   http://www.socialsecurity.gov/employer/randomizationfaqs.html
   //
   // References for historic practices:
   //   http://www.socialsecurity.gov/history/ssn/geocard.html
   //   http://www.socialsecurity.gov/employer/stateweb.htm
   //   http://www.socialsecurity.gov/employer/ssnvhighgroup.htm
 
   if (number_string.length() != 9 || !base::IsStringASCII(number_string))
     return false;
 
   int area;
-  if (!base::StringToInt(StringPiece16(number_string.begin(),
-                                       number_string.begin() + 3),
+  if (!base::StringToInt(base::StringPiece16(number_string.begin(),
+                                             number_string.begin() + 3),
                          &area)) {
     return false;
   }
   if (area < 1 ||
       area == 666 ||
       area >= 900) {
     return false;
   }
 
   int group;
-  if (!base::StringToInt(StringPiece16(number_string.begin() + 3,
-                                       number_string.begin() + 5),
+  if (!base::StringToInt(base::StringPiece16(number_string.begin() + 3,
+                                             number_string.begin() + 5),
                          &group)
       || group == 0) {
     return false;
   }
 
   int serial;
-  if (!base::StringToInt(StringPiece16(number_string.begin() + 5,
-                                       number_string.begin() + 9),
+  if (!base::StringToInt(base::StringPiece16(number_string.begin() + 5,
+                                             number_string.begin() + 9),
                          &serial)
       || serial == 0) {
     return false;
   }
 
   return true;
 }
 
 }  // namespace autofill