Make various string_util functions take StringPieces instead of char[].

chromeos/system/name_value_pairs_parser.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/system/name_value_pairs_parser.h"
 
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/process/launch.h"
 #include "base/stl_util.h"
 #include "base/strings/string_tokenizer.h"
 #include "base/strings/string_util.h"
 #include "base/sys_info.h"
 
 namespace chromeos {  // NOLINT
 namespace system {
 
 namespace {
 
-const char kQuoteChars[] = "\"";
-const char kTrimChars[] = "\" ";
-
 bool GetToolOutput(int argc, const char* argv[], std::string& output) {
   DCHECK_GE(argc, 1);
 
   if (!base::PathExists(base::FilePath(argv[0]))) {
     LOG(WARNING) << "Tool for statistics not found: " << argv[0];
     return false;
   }
 
   std::vector<std::string> args;
   for (int argn = 0; argn < argc; ++argn)
@@ skipping 30 matching lines @@
 }
 
 bool NameValuePairsParser::ParseNameValuePairsWithComments(
     const std::string& in_string,
     const std::string& eq,
     const std::string& delim,
     const std::string& comment_delim) {
   bool all_valid = true;
   // Set up the pair tokenizer.
   base::StringTokenizer pair_toks(in_string, delim);
-  pair_toks.set_quote_chars(kQuoteChars);
+  pair_toks.set_quote_chars("\"");
   // Process token pairs.
   while (pair_toks.GetNext()) {
     std::string pair(pair_toks.token());
     // Anything before the first |eq| is the key, anything after is the value.
     // |eq| must exist.
     size_t eq_pos = pair.find(eq);
     if (eq_pos != std::string::npos) {
       // First |comment_delim| after |eq_pos| starts the comment.
       // A value of |std::string::npos| means that the value spans to the end
       // of |pair|.
       size_t value_size = std::string::npos;
       if (!comment_delim.empty()) {
         size_t comment_pos = pair.find(comment_delim, eq_pos + 1);
         if (comment_pos != std::string::npos)
           value_size = comment_pos - eq_pos - 1;
       }
 
+      static const char kTrimChars[] = "\" ";
       std::string key;
       std::string value;
       base::TrimString(pair.substr(0, eq_pos), kTrimChars, &key);
       base::TrimString(pair.substr(eq_pos + 1, value_size), kTrimChars, &value);
 
       if (!key.empty()) {
         AddNameValuePair(key, value);
         continue;
       }
     }
@@ skipping 39 matching lines @@
   std::string output_string;
   if (!GetToolOutput(argc, argv, output_string))
     return false;
 
   return ParseNameValuePairsWithComments(
       output_string, eq, delim, comment_delim);
 }
 
 }  // namespace system
 }  // namespace chromeos