Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1526)

Unified Diff: chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl_unittest.cc

Issue 2965843002: [Media Router] Support dual discovery (Closed)
Patch Set: clean up and fix unit tests Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl_unittest.cc
diff --git a/chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl_unittest.cc b/chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl_unittest.cc
index c99e49001fd0c7cad4152d531b3812768f5ce0fb..359fce3346bbc3e63b7471c024bda85c6ed98c5f 100644
--- a/chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl_unittest.cc
+++ b/chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl_unittest.cc
@@ -100,7 +100,7 @@ TEST_F(DialMediaSinkServiceImplTest, TestOnDeviceDescriptionAvailable) {
media_sink_service_->OnDeviceDescriptionAvailable(device_data,
device_description);
- EXPECT_TRUE(media_sink_service_->current_sinks_.empty());
+ EXPECT_EQ(size_t(0), media_sink_service_->GetCurrentSinksSize());
std::vector<DialDeviceData> deviceList{device_data};
EXPECT_CALL(*mock_description_service_, GetDeviceDescriptions(deviceList, _));
@@ -109,7 +109,7 @@ TEST_F(DialMediaSinkServiceImplTest, TestOnDeviceDescriptionAvailable) {
media_sink_service_->OnDeviceDescriptionAvailable(device_data,
device_description);
- EXPECT_EQ(size_t(1), media_sink_service_->current_sinks_.size());
+ EXPECT_EQ(size_t(1), media_sink_service_->GetCurrentSinksSize());
imcheng 2017/07/06 22:53:30 1u
zhaobin 2017/07/10 20:21:15 Done.
imcheng 2017/07/12 00:51:35 Not done? :)
}
TEST_F(DialMediaSinkServiceImplTest, TestTimer) {

Powered by Google App Engine
This is Rietveld 408576698