chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl_unittest.cc - Issue 2965843002: [Media Router] Support dual discovery

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl_unittest.cc

Issue 2965843002: [Media Router] Support dual discovery (Closed)

Patch Set: resovle code review comments from Derek and Mark Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl.cc ('k') | chrome/browser/media/router/discovery/dial/dial_media_sink_service_proxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl_unittest.cc

diff --git a/chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl_unittest.cc b/chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl_unittest.cc

index c99e49001fd0c7cad4152d531b3812768f5ce0fb..d33c7ad1cb3c649272536511b63f543138fce518 100644

--- a/chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl_unittest.cc

+++ b/chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl_unittest.cc

@@ -7,6 +7,7 @@

#include "base/timer/mock_timer.h"

#include "chrome/browser/media/router/discovery/dial/dial_device_data.h"

#include "chrome/browser/media/router/discovery/dial/dial_registry.h"

+#include "chrome/browser/media/router/discovery/mdns/cast_media_sink_service.h"

#include "chrome/browser/media/router/test_helper.h"

#include "chrome/test/base/testing_profile.h"

#include "content/public/test/test_browser_thread_bundle.h"

@@ -109,7 +110,7 @@ TEST_F(DialMediaSinkServiceImplTest, TestOnDeviceDescriptionAvailable) {

media_sink_service_->OnDeviceDescriptionAvailable(device_data,

device_description);

- EXPECT_EQ(size_t(1), media_sink_service_->current_sinks_.size());

+ EXPECT_EQ(1u, media_sink_service_->current_sinks_.size());

}

TEST_F(DialMediaSinkServiceImplTest, TestTimer) {