Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(977)

Unified Diff: chrome/browser/media/router/discovery/dial/dial_media_sink_service_proxy_unittest.cc

Issue 2965843002: [Media Router] Support dual discovery (Closed)
Patch Set: resolve code review comments from Derek Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/discovery/dial/dial_media_sink_service_proxy_unittest.cc
diff --git a/chrome/browser/media/router/discovery/dial/dial_media_sink_service_proxy_unittest.cc b/chrome/browser/media/router/discovery/dial/dial_media_sink_service_proxy_unittest.cc
index 9c114e9d8190cda0a8f1dcc73684e32ee6642fe1..f9e140cad308cee1a7a49534107cda924877b9ad 100644
--- a/chrome/browser/media/router/discovery/dial/dial_media_sink_service_proxy_unittest.cc
+++ b/chrome/browser/media/router/discovery/dial/dial_media_sink_service_proxy_unittest.cc
@@ -6,6 +6,7 @@
#include "base/run_loop.h"
#include "base/test/mock_callback.h"
#include "chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl.h"
+#include "chrome/browser/media/router/discovery/mdns/cast_media_sink_service.h"
#include "chrome/browser/media/router/test_helper.h"
#include "chrome/test/base/testing_profile.h"
#include "content/public/test/test_browser_thread_bundle.h"
@@ -23,8 +24,11 @@ class MockDialMediaSinkServiceImpl : public DialMediaSinkServiceImpl {
MockDialMediaSinkServiceImpl(
const MediaSinkService::OnSinksDiscoveredCallback&
sink_discovery_callback,
+ scoped_refptr<CastMediaSinkService> cast_media_sink_service,
net::URLRequestContextGetter* request_context)
- : DialMediaSinkServiceImpl(sink_discovery_callback, request_context) {}
+ : DialMediaSinkServiceImpl(sink_discovery_callback,
+ cast_media_sink_service,
+ request_context) {}
~MockDialMediaSinkServiceImpl() override {}
MOCK_METHOD0(Start, void());
@@ -39,12 +43,13 @@ class DialMediaSinkServiceProxyTest : public ::testing::Test {
public:
DialMediaSinkServiceProxyTest()
: proxy_(new DialMediaSinkServiceProxy(mock_sink_discovered_cb_.Get(),
+ nullptr,
&profile_)) {
std::unique_ptr<MockDialMediaSinkServiceImpl> mock_dial_media_sink_service =
base::MakeUnique<MockDialMediaSinkServiceImpl>(
base::Bind(&DialMediaSinkServiceProxy::OnSinksDiscoveredOnIOThread,
base::Unretained(proxy_.get())),
- profile_.GetRequestContext());
+ nullptr, profile_.GetRequestContext());
mock_service_ = mock_dial_media_sink_service.get();
proxy_->SetDialMediaSinkServiceForTest(
std::move(mock_dial_media_sink_service));

Powered by Google App Engine
This is Rietveld 408576698