[Media Router] Support dual discovery

chrome/browser/media/router/discovery/mdns/cast_media_sink_service.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_MEDIA_ROUTER_DISCOVERY_MDNS_CAST_MEDIA_SINK_SERVICE_H_
 #define CHROME_BROWSER_MEDIA_ROUTER_DISCOVERY_MDNS_CAST_MEDIA_SINK_SERVICE_H_
 
 #include <memory>
 #include <set>
 
@@ skipping 15 matching lines @@
 class BrowserContext;
 }  // namespace content
 
 namespace media_router {
 
 // A service which can be used to start background discovery and resolution of
 // Cast devices.
 // Public APIs should be invoked on the UI thread.
 class CastMediaSinkService
     : public MediaSinkServiceBase,
+      public MediaSinkService::Observer,
       public DnsSdRegistry::DnsSdObserver,
       public base::RefCountedThreadSafe<CastMediaSinkService> {
  public:
   CastMediaSinkService(const OnSinksDiscoveredCallback& callback,
                        content::BrowserContext* browser_context);
 
   // Used by unit tests.
   CastMediaSinkService(const OnSinksDiscoveredCallback& callback,
                        cast_channel::CastSocketService* cast_socket_service);
 
   // mDNS service types.
   static const char kCastServiceType[];

[imcheng, 2017/07/06 22:53:30]

Can this and kCastControlPort be constexpr and be defined here?

[zhaobin, 2017/07/10 20:21:15]

Yes, but still need to define it again in .cc file. Leave it as it is?

 
+  // Default Cast control port to open Cast Socket from DIAL sink.
+  static int kCastControlPort;
+
   // MediaSinkService implementation
   void Start() override;
   void Stop() override;
 
+  // MediaSinkService::Observer implementation
+  void OnMediaSinkAdded(const MediaSinkInternal& sink) override;
+  void OnMediaSinksRemoved() override;
+
  protected:
   // Used to mock out the DnsSdRegistry for testing.
   void SetDnsSdRegistryForTest(DnsSdRegistry* registry);
 
   ~CastMediaSinkService() override;
 
  private:
   // Receives incoming messages and errors and provides additional API context.
   class CastSocketObserver : public cast_channel::CastSocket::Observer {
    public:
@@ skipping 15 matching lines @@
 
   FRIEND_TEST_ALL_PREFIXES(CastMediaSinkServiceTest, TestReStartAfterStop);
   FRIEND_TEST_ALL_PREFIXES(CastMediaSinkServiceTest, TestMultipleStartAndStop);
   FRIEND_TEST_ALL_PREFIXES(CastMediaSinkServiceTest,
                            TestOnChannelOpenedOnIOThread);
   FRIEND_TEST_ALL_PREFIXES(CastMediaSinkServiceTest,
                            TestMultipleOnChannelOpenedOnIOThread);
   FRIEND_TEST_ALL_PREFIXES(CastMediaSinkServiceTest, TestOnDnsSdEvent);
   FRIEND_TEST_ALL_PREFIXES(CastMediaSinkServiceTest, TestMultipleOnDnsSdEvent);
   FRIEND_TEST_ALL_PREFIXES(CastMediaSinkServiceTest, TestTimer);
+  FRIEND_TEST_ALL_PREFIXES(CastMediaSinkServiceTest, TestOnDialSinkAdded);
+  FRIEND_TEST_ALL_PREFIXES(CastMediaSinkServiceTest, TestOnFetchCompleted);
+
+  // MediaSinkServiceBase implementation
+  void OnFetchCompleted() override;
 
   // DnsSdRegistry::DnsSdObserver implementation
   void OnDnsSdEvent(const std::string& service_type,
                     const DnsSdRegistry::DnsSdServiceList& services) override;
 
-  // Opens cast channel on IO thread.
-  // |service|: mDNS service description.
+  // Open cast channel on IO thread.
   // |ip_endpoint|: cast channel's target IP endpoint.
-  void OpenChannelOnIOThread(const DnsSdService& service,
-                             const net::IPEndPoint& ip_endpoint);
+  // |on_open_callback|: callback to be invoked on the IO thread when Cast
+  // socket opens.
+  void OpenChannelOnIOThread(
+      const net::IPEndPoint& ip_endpoint,
+      const cast_channel::CastSocket::OnOpenCallback& on_open_callback);
 
   // Invoked when opening cast channel on IO thread completes.
-  // |service|: mDNS service description.
+  // |cast_sink|: Cast sink created from mDNS service description or DIAL sink.
   // |channel_id|: channel id of newly created cast channel.
   // |channel_error|: error encounted when opending cast channel.
-  void OnChannelOpenedOnIOThread(const DnsSdService& service,
+  void OnChannelOpenedOnIOThread(const MediaSinkInternal& cast_sink,
                                  int channel_id,
                                  cast_channel::ChannelError channel_error);
 
   // Invoked by |OnChannelOpenedOnIOThread| to post task on UI thread.
-  // |service|: mDNS service description.
-  // |channel_id|: channel id of newly created cast channel.
-  // |audio_only|: if cast channel is audio only or not.
-  void OnChannelOpenedOnUIThread(const DnsSdService& service,
-                                 int channel_id,
-                                 bool audio_only);
+  // |cast_sink|: Cast sink created from mDNS service description  or DIAL sink.
+  void OnChannelOpenedOnUIThread(const MediaSinkInternal& cast_sink);
 
   // Raw pointer to DnsSdRegistry instance, which is a global leaky singleton
   // and lives as long as the browser process.
   DnsSdRegistry* dns_sd_registry_ = nullptr;
 
-  // Service list from current round of discovery.
-  DnsSdRegistry::DnsSdServiceList current_services_;
+  // Set of mDNS service ip addresses from current round of discovery.
+  std::set<net::IPEndPoint> current_service_ip_endpoints_;
+
+  // Map of sinks from current round of mDNS discovery keyed by IP address.
+  std::map<net::IPEndPoint, MediaSinkInternal> current_sinks_by_mdns_map_;
+
+  // Map of sinks from current round of DIAL discovery keyed by IP address.
+  std::map<net::IPEndPoint, MediaSinkInternal> current_sinks_by_dial_map_;
 
   // Service managing creating and removing cast channels.
   scoped_refptr<cast_channel::CastSocketService> cast_socket_service_;
 
   THREAD_CHECKER(thread_checker_);
 
   DISALLOW_COPY_AND_ASSIGN(CastMediaSinkService);
 };
 
 }  // namespace media_router
 
 #endif  // CHROME_BROWSER_MEDIA_ROUTER_DISCOVERY_MDNS_CAST_MEDIA_SINK_SERVICE_H_