mojo/public/tools/bindings/generators/js_templates/module_definition.tmpl - Issue 2965803003: Mojo JS bindings: add support to generate "dual-mode" code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/js_templates/module_definition.tmpl

Issue 2965803003: Mojo JS bindings: add support to generate "dual-mode" code. (Closed)

Patch Set: . Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/usb_internals/usb_internals.js ('K') | « mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl ('k') | mojo/public/tools/bindings/generators/mojom_js_generator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/js_templates/module_definition.tmpl

diff --git a/mojo/public/tools/bindings/generators/js_templates/module_definition.tmpl b/mojo/public/tools/bindings/generators/js_templates/module_definition.tmpl

index 7d7f06558aa1c8bcba6af0268680054a73758e03..53369ee0eeb0d9bc627eff1ecdbd2e64b4591509 100644

--- a/mojo/public/tools/bindings/generators/js_templates/module_definition.tmpl

+++ b/mojo/public/tools/bindings/generators/js_templates/module_definition.tmpl

@@ -25,11 +25,10 @@

{%- include "interface_definition.tmpl" %}

{%- endfor %}

-{%- if use_new_js_bindings %}

- var exports = mojo.internal.exposeNamespace("{{module.namespace}}");

-{%- else %}

var exports = {};

-{%- endif %}

+ if (mojo && mojo.internal) {

+ exports = mojo.internal.exposeNamespace("{{module.namespace}}");

+ }

{%- for constant in module.constants %}

exports.{{constant.name}} = {{constant.name}};