Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Side by Side Diff: chrome/browser/printing/printer_manager_dialog_win.cc

Issue 2965803002: Move more printing code off of the FILE thread. (Closed)
Patch Set: tweak Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/printing/printer_manager_dialog_linux.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/printing/printer_manager_dialog.h" 5 #include "chrome/browser/printing/printer_manager_dialog.h"
6 6
7 #include <windows.h> 7 #include <windows.h>
8 #include <shellapi.h> 8 #include <shellapi.h>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
11 #include "base/files/file_path.h" 11 #include "base/files/file_path.h"
12 #include "base/path_service.h" 12 #include "base/path_service.h"
13 #include "base/task_scheduler/post_task.h"
13 #include "base/threading/thread.h" 14 #include "base/threading/thread.h"
14 #include "chrome/browser/browser_process.h"
15 #include "content/public/browser/browser_thread.h"
16 15
17 using content::BrowserThread; 16 namespace {
18
19 namespace printing {
20 17
21 // A helper callback that opens the printer management dialog. 18 // A helper callback that opens the printer management dialog.
22 void OpenPrintersDialogCallback() { 19 void OpenPrintersDialogCallback() {
23 base::FilePath sys_dir; 20 base::FilePath sys_dir;
24 PathService::Get(base::DIR_SYSTEM, &sys_dir); 21 PathService::Get(base::DIR_SYSTEM, &sys_dir);
25 base::FilePath rundll32 = sys_dir.AppendASCII("rundll32.exe"); 22 base::FilePath rundll32 = sys_dir.Append(L"rundll32.exe");
26 base::FilePath shell32dll = sys_dir.AppendASCII("shell32.dll"); 23 base::FilePath shell32dll = sys_dir.Append(L"shell32.dll");
27 24
28 std::wstring args(shell32dll.value()); 25 std::wstring args(shell32dll.value());
29 args.append(L",SHHelpShortcuts_RunDLL PrintersFolder"); 26 args.append(L",SHHelpShortcuts_RunDLL PrintersFolder");
30 ShellExecute(NULL, L"open", rundll32.value().c_str(), args.c_str(), NULL, 27 ShellExecute(nullptr, L"open", rundll32.value().c_str(), args.c_str(),
31 SW_SHOWNORMAL); 28 nullptr, SW_SHOWNORMAL);
32 } 29 }
33 30
31 } // namespace
32
33 namespace printing {
34
34 void PrinterManagerDialog::ShowPrinterManagerDialog() { 35 void PrinterManagerDialog::ShowPrinterManagerDialog() {
35 BrowserThread::PostTask( 36 base::PostTaskWithTraits(
36 BrowserThread::FILE, 37 FROM_HERE, {base::MayBlock(), base::TaskPriority::USER_BLOCKING},
37 FROM_HERE,
38 base::Bind(OpenPrintersDialogCallback)); 38 base::Bind(OpenPrintersDialogCallback));
39 } 39 }
40 40
41 } // namespace printing 41 } // namespace printing
OLDNEW
« no previous file with comments | « chrome/browser/printing/printer_manager_dialog_linux.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698