Support break in switch and break/continue in do statements

Support break in switch and break/continue in do statements

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/8d9562ecd06d62e49a666b76a52abd1adc707e4d

[Johnni Winther, 2017-06-30 18:03:17]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-06-30 18:16:21]

lgtm

https://codereview.chromium.org/2965763002/diff/1/pkg/compiler/lib/src/js_mod...
File pkg/compiler/lib/src/js_model/locals.dart (right):

https://codereview.chromium.org/2965763002/diff/1/pkg/compiler/lib/src/js_mod...
pkg/compiler/lib/src/js_model/locals.dart:160: // TODO(johnniwinther): Add more.
anything more to add for break?

https://codereview.chromium.org/2965763002/diff/1/pkg/compiler/lib/src/js_mod...
pkg/compiler/lib/src/js_model/locals.dart:164: node is ir.DoStatement ||
I thought you said there was more to this than just removing the .parent, did
something else change?

https://codereview.chromium.org/2965763002/diff/1/pkg/compiler/lib/src/js_mod...
pkg/compiler/lib/src/js_model/locals.dart:169: // TODO(johnniwinther): Add more.
here we are missing continue to switch-case, correct? anything else?

[Johnni Winther, 2017-06-30 19:16:35]

Patchset #3 (id:40001) has been deleted

[Johnni Winther, 2017-06-30 19:16:55]

https://codereview.chromium.org/2965763002/diff/1/pkg/compiler/lib/src/js_mod...
File pkg/compiler/lib/src/js_model/locals.dart (right):

https://codereview.chromium.org/2965763002/diff/1/pkg/compiler/lib/src/js_mod...
pkg/compiler/lib/src/js_model/locals.dart:160: // TODO(johnniwinther): Add more.
On 2017/06/30 18:16:21, Siggi Cherem (dart-lang) wrote:
> anything more to add for break?

No. Removed.

https://codereview.chromium.org/2965763002/diff/1/pkg/compiler/lib/src/js_mod...
pkg/compiler/lib/src/js_model/locals.dart:164: node is ir.DoStatement ||
On 2017/06/30 18:16:21, Siggi Cherem (dart-lang) wrote:
> I thought you said there was more to this than just removing the .parent, did
> something else change?

The problem was that continue in do requires a label, which we cannot currently
test.

https://codereview.chromium.org/2965763002/diff/1/pkg/compiler/lib/src/js_mod...
pkg/compiler/lib/src/js_model/locals.dart:169: // TODO(johnniwinther): Add more.
On 2017/06/30 18:16:21, Siggi Cherem (dart-lang) wrote:
> here we are missing continue to switch-case, correct? anything else?

That's the only one.

[Johnni Winther, 2017-06-30 19:17:16]

Description was changed from

==========
Support break in switch and break/continue in do statements
==========

to

==========
Support break in switch and break/continue in do statements

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8d9562ecd06d62e49a666b76a52abd1adc707e4d
==========

[Johnni Winther, 2017-06-30 19:17:18]

Committed patchset #2 (id:20001) manually as
8d9562ecd06d62e49a666b76a52abd1adc707e4d (presubmit successful).