Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Unified Diff: components/metrics/file_metrics_provider.h

Issue 2965753002: [Cleanup] Migrate the FileMetricsProvider to use the Task Scheduler. (Closed)
Patch Set: Change DCHECK syntax Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/file_metrics_provider.h
diff --git a/components/metrics/file_metrics_provider.h b/components/metrics/file_metrics_provider.h
index 6573475b4d178c3a6b2f70696e2f1ee3573198c8..66ce26612fa7f5c68851500a5d8f9507f2152eaa 100644
--- a/components/metrics/file_metrics_provider.h
+++ b/components/metrics/file_metrics_provider.h
@@ -14,7 +14,7 @@
#include "base/gtest_prod_util.h"
#include "base/memory/weak_ptr.h"
#include "base/metrics/statistics_recorder.h"
-#include "base/threading/thread_checker.h"
+#include "base/sequence_checker.h"
#include "base/time/time.h"
#include "components/metrics/metrics_provider.h"
@@ -97,8 +97,7 @@ class FileMetricsProvider : public MetricsProvider,
ASSOCIATE_INTERNAL_PROFILE_OR_PREVIOUS_RUN,
};
- FileMetricsProvider(const scoped_refptr<base::TaskRunner>& task_runner,
- PrefService* local_state);
+ explicit FileMetricsProvider(PrefService* local_state);
~FileMetricsProvider() override;
// Indicates a file or directory to be monitored and how the file or files
@@ -119,6 +118,10 @@ class FileMetricsProvider : public MetricsProvider,
static void RegisterPrefs(PrefRegistrySimple* prefs,
const base::StringPiece prefs_key);
+ // Sets the task runner to use for testing.
+ static void SetTaskRunnerForTesting(
+ const scoped_refptr<base::TaskRunner>& task_runner);
+
private:
friend class FileMetricsProviderTest;
@@ -225,7 +228,7 @@ class FileMetricsProvider : public MetricsProvider,
// The preferences-service used to store persistent state about sources.
PrefService* pref_service_;
- base::ThreadChecker thread_checker_;
+ SEQUENCE_CHECKER(sequence_checker_);
base::WeakPtrFactory<FileMetricsProvider> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(FileMetricsProvider);
« no previous file with comments | « chrome/browser/metrics/chrome_metrics_service_client.cc ('k') | components/metrics/file_metrics_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698