Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Side by Side Diff: chrome/browser/metrics/chrome_metrics_service_client.cc

Issue 2965753002: [Cleanup] Migrate the FileMetricsProvider to use the Task Scheduler. (Closed)
Patch Set: Change DCHECK syntax Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/metrics/file_metrics_provider.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/metrics/chrome_metrics_service_client.h" 5 #include "chrome/browser/metrics/chrome_metrics_service_client.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
11 #include <vector> 11 #include <vector>
12 12
13 #include "base/bind.h" 13 #include "base/bind.h"
14 #include "base/callback.h" 14 #include "base/callback.h"
15 #include "base/command_line.h" 15 #include "base/command_line.h"
16 #include "base/files/file_path.h" 16 #include "base/files/file_path.h"
17 #include "base/files/file_util.h" 17 #include "base/files/file_util.h"
18 #include "base/lazy_instance.h" 18 #include "base/lazy_instance.h"
19 #include "base/logging.h" 19 #include "base/logging.h"
20 #include "base/memory/ptr_util.h" 20 #include "base/memory/ptr_util.h"
21 #include "base/metrics/field_trial_params.h" 21 #include "base/metrics/field_trial_params.h"
22 #include "base/metrics/histogram_macros.h" 22 #include "base/metrics/histogram_macros.h"
23 #include "base/metrics/persistent_histogram_allocator.h" 23 #include "base/metrics/persistent_histogram_allocator.h"
24 #include "base/metrics/persistent_memory_allocator.h" 24 #include "base/metrics/persistent_memory_allocator.h"
25 #include "base/metrics/statistics_recorder.h" 25 #include "base/metrics/statistics_recorder.h"
26 #include "base/path_service.h" 26 #include "base/path_service.h"
27 #include "base/rand_util.h" 27 #include "base/rand_util.h"
28 #include "base/strings/string16.h" 28 #include "base/strings/string16.h"
29 #include "base/task_scheduler/post_task.h" 29 #include "base/task_scheduler/post_task.h"
30 #include "base/task_scheduler/task_traits.h"
30 #include "base/threading/platform_thread.h" 31 #include "base/threading/platform_thread.h"
31 #include "base/threading/sequenced_worker_pool.h"
32 #include "base/threading/thread_task_runner_handle.h" 32 #include "base/threading/thread_task_runner_handle.h"
33 #include "build/build_config.h" 33 #include "build/build_config.h"
34 #include "chrome/browser/browser_process.h" 34 #include "chrome/browser/browser_process.h"
35 #include "chrome/browser/chrome_notification_types.h" 35 #include "chrome/browser/chrome_notification_types.h"
36 #include "chrome/browser/google/google_brand.h" 36 #include "chrome/browser/google/google_brand.h"
37 #include "chrome/browser/history/history_service_factory.h" 37 #include "chrome/browser/history/history_service_factory.h"
38 #include "chrome/browser/metrics/chrome_metrics_service_accessor.h" 38 #include "chrome/browser/metrics/chrome_metrics_service_accessor.h"
39 #include "chrome/browser/metrics/chrome_stability_metrics_provider.h" 39 #include "chrome/browser/metrics/chrome_stability_metrics_provider.h"
40 #include "chrome/browser/metrics/https_engagement_metrics_provider.h" 40 #include "chrome/browser/metrics/https_engagement_metrics_provider.h"
41 #include "chrome/browser/metrics/metrics_reporting_state.h" 41 #include "chrome/browser/metrics/metrics_reporting_state.h"
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 } 172 }
173 173
174 // Constructs the name of a persistent metrics file from a directory and metrics 174 // Constructs the name of a persistent metrics file from a directory and metrics
175 // name, and either registers that file as associated with a previous run if 175 // name, and either registers that file as associated with a previous run if
176 // metrics reporting is enabled, or deletes it if not. 176 // metrics reporting is enabled, or deletes it if not.
177 void RegisterOrRemovePreviousRunMetricsFile( 177 void RegisterOrRemovePreviousRunMetricsFile(
178 bool metrics_reporting_enabled, 178 bool metrics_reporting_enabled,
179 const base::FilePath& dir, 179 const base::FilePath& dir,
180 base::StringPiece metrics_name, 180 base::StringPiece metrics_name,
181 metrics::FileMetricsProvider::SourceAssociation association, 181 metrics::FileMetricsProvider::SourceAssociation association,
182 scoped_refptr<base::TaskRunner> task_runner,
183 metrics::FileMetricsProvider* file_metrics_provider) { 182 metrics::FileMetricsProvider* file_metrics_provider) {
184 base::FilePath metrics_file; 183 base::FilePath metrics_file;
185 base::GlobalHistogramAllocator::ConstructFilePaths( 184 base::GlobalHistogramAllocator::ConstructFilePaths(
186 dir, metrics_name, &metrics_file, nullptr, nullptr); 185 dir, metrics_name, &metrics_file, nullptr, nullptr);
187 186
188 if (metrics_reporting_enabled) { 187 if (metrics_reporting_enabled) {
189 // Enable reading any existing saved metrics. 188 // Enable reading any existing saved metrics.
190 file_metrics_provider->RegisterSource( 189 file_metrics_provider->RegisterSource(
191 metrics_file, 190 metrics_file,
192 metrics::FileMetricsProvider::SOURCE_HISTOGRAMS_ATOMIC_FILE, 191 metrics::FileMetricsProvider::SOURCE_HISTOGRAMS_ATOMIC_FILE,
193 association, metrics_name); 192 association, metrics_name);
194 } else { 193 } else {
195 // When metrics reporting is not enabled, any existing file should be 194 // When metrics reporting is not enabled, any existing file should be
196 // deleted in order to preserve user privacy. 195 // deleted in order to preserve user privacy.
197 task_runner->PostTask(FROM_HERE, 196 base::PostTaskWithTraits(
198 base::BindOnce(base::IgnoreResult(&base::DeleteFile), 197 FROM_HERE,
199 metrics_file, /*recursive=*/false)); 198 {base::MayBlock(), base::TaskPriority::BACKGROUND,
199 base::TaskShutdownBehavior::CONTINUE_ON_SHUTDOWN},
200 base::BindOnce(base::IgnoreResult(&base::DeleteFile), metrics_file,
201 /*recursive=*/false));
200 } 202 }
201 } 203 }
202 204
203 std::unique_ptr<metrics::FileMetricsProvider> CreateFileMetricsProvider( 205 std::unique_ptr<metrics::FileMetricsProvider> CreateFileMetricsProvider(
204 bool metrics_reporting_enabled) { 206 bool metrics_reporting_enabled) {
205 // Fetch a worker-pool for performing I/O tasks that are not allowed on
206 // the main UI thread.
207 scoped_refptr<base::TaskRunner> task_runner =
208 content::BrowserThread::GetBlockingPool()
209 ->GetTaskRunnerWithShutdownBehavior(
210 base::SequencedWorkerPool::CONTINUE_ON_SHUTDOWN);
211
212 // Create an object to monitor files of metrics and include them in reports. 207 // Create an object to monitor files of metrics and include them in reports.
213 std::unique_ptr<metrics::FileMetricsProvider> file_metrics_provider( 208 std::unique_ptr<metrics::FileMetricsProvider> file_metrics_provider(
214 new metrics::FileMetricsProvider(task_runner, 209 new metrics::FileMetricsProvider(g_browser_process->local_state()));
215 g_browser_process->local_state()));
216 210
217 base::FilePath user_data_dir; 211 base::FilePath user_data_dir;
218 if (base::PathService::Get(chrome::DIR_USER_DATA, &user_data_dir)) { 212 if (base::PathService::Get(chrome::DIR_USER_DATA, &user_data_dir)) {
219 // Register the Crashpad metrics files. 213 // Register the Crashpad metrics files.
220 // Register the data from the previous run if crashpad_handler didn't exit 214 // Register the data from the previous run if crashpad_handler didn't exit
221 // cleanly. 215 // cleanly.
222 RegisterOrRemovePreviousRunMetricsFile( 216 RegisterOrRemovePreviousRunMetricsFile(
223 metrics_reporting_enabled, user_data_dir, 217 metrics_reporting_enabled, user_data_dir,
224 kCrashpadHistogramAllocatorName, 218 kCrashpadHistogramAllocatorName,
225 metrics::FileMetricsProvider:: 219 metrics::FileMetricsProvider::
226 ASSOCIATE_INTERNAL_PROFILE_OR_PREVIOUS_RUN, 220 ASSOCIATE_INTERNAL_PROFILE_OR_PREVIOUS_RUN,
227 task_runner, file_metrics_provider.get()); 221 file_metrics_provider.get());
228 222
229 base::FilePath browser_metrics_upload_dir = user_data_dir.AppendASCII( 223 base::FilePath browser_metrics_upload_dir = user_data_dir.AppendASCII(
230 ChromeMetricsServiceClient::kBrowserMetricsName); 224 ChromeMetricsServiceClient::kBrowserMetricsName);
231 if (metrics_reporting_enabled) { 225 if (metrics_reporting_enabled) {
232 file_metrics_provider->RegisterSource( 226 file_metrics_provider->RegisterSource(
233 browser_metrics_upload_dir, 227 browser_metrics_upload_dir,
234 metrics::FileMetricsProvider::SOURCE_HISTOGRAMS_ATOMIC_DIR, 228 metrics::FileMetricsProvider::SOURCE_HISTOGRAMS_ATOMIC_DIR,
235 metrics::FileMetricsProvider::ASSOCIATE_INTERNAL_PROFILE, 229 metrics::FileMetricsProvider::ASSOCIATE_INTERNAL_PROFILE,
236 ChromeMetricsServiceClient::kBrowserMetricsName); 230 ChromeMetricsServiceClient::kBrowserMetricsName);
237 231
(...skipping 775 matching lines...) Expand 10 before | Expand all | Expand 10 after
1013 ukm_service_->Purge(); 1007 ukm_service_->Purge();
1014 ukm_service_->ResetClientId(); 1008 ukm_service_->ResetClientId();
1015 } 1009 }
1016 // Signal service manager to enable/disable UKM based on new state. 1010 // Signal service manager to enable/disable UKM based on new state.
1017 UpdateRunningServices(); 1011 UpdateRunningServices();
1018 } 1012 }
1019 1013
1020 bool ChromeMetricsServiceClient::IsHistorySyncEnabledOnAllProfiles() { 1014 bool ChromeMetricsServiceClient::IsHistorySyncEnabledOnAllProfiles() {
1021 return SyncDisableObserver::IsHistorySyncEnabledOnAllProfiles(); 1015 return SyncDisableObserver::IsHistorySyncEnabledOnAllProfiles();
1022 } 1016 }
OLDNEW
« no previous file with comments | « no previous file | components/metrics/file_metrics_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698