[VM, generic functions reification, work in progress]

[VM, generic functions reification, work in progress]
Do not consider a generic function type as uninstantiated if all the function
type parameters appearing in its signature are declared by the type itself.
The generic function type is uninstantiated if it refers to function type
parameters of parent generic functions, or to class type parameters.

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/2252d0dcc5cdb446116049634c3e9e0c48b4270a

[regis, 2017-06-30 16:37:32]

regis@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2017-06-30 21:52:27]

lgtm

https://codereview.chromium.org/2965743002/diff/1/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/2965743002/diff/1/runtime/vm/object.h#newcode...
runtime/vm/object.h:1662: intptr_t num_free_fun_type_params = kMaxInt32,
2 billion type parameters should be enough for anyone!

[regis, 2017-06-30 22:03:37]

On 2017/06/30 21:52:27, rmacnak wrote:
> lgtm
> 
> https://codereview.chromium.org/2965743002/diff/1/runtime/vm/object.h
> File runtime/vm/object.h (right):
> 
>
https://codereview.chromium.org/2965743002/diff/1/runtime/vm/object.h#newcode...
> runtime/vm/object.h:1662: intptr_t num_free_fun_type_params = kMaxInt32,
> 2 billion type parameters should be enough for anyone!

I thought so too. We'll see :-)

Thanks!

[regis, 2017-06-30 22:04:21]

Description was changed from

==========
[VM, generic functions reification, work in progress]
Do not consider a generic function type as uninstantiated if all the function
type parameters appearing in its signature are declared by the type itself.
The generic function type is uninstantiated if it refers to function type
parameters of parent generic functions, or to class type parameters.
==========

to

==========
[VM, generic functions reification, work in progress]
Do not consider a generic function type as uninstantiated if all the function
type parameters appearing in its signature are declared by the type itself.
The generic function type is uninstantiated if it refers to function type
parameters of parent generic functions, or to class type parameters.

R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/2252d0dcc5cdb446116049634c3e9e0c48b4270a
==========

[regis, 2017-06-30 22:04:22]

Committed patchset #1 (id:1) manually as
2252d0dcc5cdb446116049634c3e9e0c48b4270a (presubmit successful).