runtime/vm/profiler.cc - Issue 2965723002: VM: Reland Inline instance object hash code into object header on 64bit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/profiler.cc

Issue 2965723002: VM: Reland Inline instance object hash code into object header on 64bit. (Closed)

Patch Set: Fix snapshot incompatibility that sank Flutter Gallery Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/profiler.cc

diff --git a/runtime/vm/profiler.cc b/runtime/vm/profiler.cc

index aba94b69bca4e16688ad5c2a62659db992e5c3e5..b416aeb5095f7de3cee46e1c4e3a521c57c5e33a 100644

--- a/runtime/vm/profiler.cc

+++ b/runtime/vm/profiler.cc

@@ -1330,7 +1330,7 @@ class CodeLookupTableBuilder : public ObjectVisitor {

~CodeLookupTableBuilder() {}

void VisitObject(RawObject* raw_obj) {

- uword tags = raw_obj->ptr()->tags_;

+ uint32_t tags = raw_obj->ptr()->tags_;

if (RawObject::ClassIdTag::decode(tags) == kCodeCid) {

RawCode* raw_code = reinterpret_cast<RawCode*>(raw_obj);

const Code& code = Code::Handle(raw_code);