Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Issue 2965673004: Fix setting breakpoints in parts of a library. (Closed)

Created:
3 years, 5 months ago by sivachandra
Modified:
3 years, 5 months ago
Reviewers:
rmacnak, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix setting breakpoints in parts of a library. This fixes the regression caused by 1eaa3dd84baf04db4ab7c437c734dceaa27785a3 and reported in #29988. When picking a class to set a breakpoint, instead of rejecting classes not defined in the script, we now reject classes which do not belong to the library to which the script belongs. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/f0ef900fd3e20f0513be7fc13da36dbf89f2e1ac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -1 line) Patch
M runtime/tests/vm/vm.status View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/debugger.cc View 3 chunks +10 lines, -1 line 0 comments Download
M runtime/vm/debugger_test.cc View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sivachandra
3 years, 5 months ago (2017-06-30 23:33:58 UTC) #2
sivachandra
ping.
3 years, 5 months ago (2017-07-07 00:12:55 UTC) #3
sivachandra
On 2017/07/07 00:12:55, sivachandra wrote: > ping. ping.
3 years, 5 months ago (2017-07-10 17:25:29 UTC) #4
siva
lgtm
3 years, 5 months ago (2017-07-10 17:38:43 UTC) #5
sivachandra
3 years, 5 months ago (2017-07-11 00:20:32 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f0ef900fd3e20f0513be7fc13da36dbf89f2e1ac (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698