Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: components/net_log/net_log_file_writer.h

Issue 2965623002: Fix about:flags information not showing up in chrome://net-export/ logs (Closed)
Patch Set: . Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/net_log/net_log_file_writer.h
diff --git a/components/net_log/net_log_file_writer.h b/components/net_log/net_log_file_writer.h
index 1f741c9e1d3c0c7efd502e9323d1f98add7bf636..49899c33233e3656626df2d8fed4932a8dde3abb 100644
--- a/components/net_log/net_log_file_writer.h
+++ b/components/net_log/net_log_file_writer.h
@@ -105,6 +105,8 @@ class NetLogFileWriter {
// thread.
void StartNetLog(const base::FilePath& log_path,
net::NetLogCaptureMode capture_mode,
+ const base::CommandLine::StringType& command_line_string,
+ const std::string& channel_string,
const URLRequestContextGetterList& context_getters);
// Stops collecting NetLog data into the file. It is a no-op if
@@ -149,9 +151,7 @@ class NetLogFileWriter {
protected:
// Constructs a NetLogFileWriter. Only one instance is created in browser
// process.
- NetLogFileWriter(ChromeNetLog* chrome_net_log,
- const base::CommandLine::StringType& command_line_string,
- const std::string& channel_string);
+ explicit NetLogFileWriter(ChromeNetLog* chrome_net_log);
private:
friend class ChromeNetLog;
@@ -228,9 +228,6 @@ class NetLogFileWriter {
// List of StateObservers to notify on state changes.
base::ObserverList<StateObserver, true> state_observer_list_;
- const base::CommandLine::StringType command_line_string_;
- const std::string channel_string_;
-
// Used by unit tests to override the default log base directory retrieved
// during initialization. This getter is initialized to base::GetTempDir().
DirectoryGetter default_log_base_dir_getter_;

Powered by Google App Engine
This is Rietveld 408576698