Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: components/net_log/chrome_net_log.h

Issue 2965623002: Fix about:flags information not showing up in chrome://net-export/ logs (Closed)
Patch Set: . Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/net_log/chrome_net_log.h
diff --git a/components/net_log/chrome_net_log.h b/components/net_log/chrome_net_log.h
index bca0d2889df66b0b9f08723754154dc94a0e0cf3..30ccb9e211f8ad4aa286754aad25fc3c618e6131 100644
--- a/components/net_log/chrome_net_log.h
+++ b/components/net_log/chrome_net_log.h
@@ -30,6 +30,12 @@ class NetLogFileWriter;
// as its observers.
class ChromeNetLog : public net::NetLog {
public:
+ // The parameters to the constructor are only used for command-line based
+ // NetLog writing (which starts immediately after construction).
+ //
+ // TODO(eroman): This would be clearer as a separate method to configure and
+ // start this logging mode.
+ //
// The log is saved to |log_file|.
// |log_file_mode| is the mode used to log in |log_file|.
// If |log_file| is empty, only a temporary log is created, and
@@ -40,7 +46,9 @@ class ChromeNetLog : public net::NetLog {
const std::string& channel_string);
~ChromeNetLog() override;
- NetLogFileWriter* net_log_file_writer() { return net_log_file_writer_.get(); }
+ // TODO(eroman): Rename this to something clearer. Perhaps
+ // |net_export_file_writer()|.
+ NetLogFileWriter* net_log_file_writer();
// Returns a Value containing constants needed to load a log file.
// Safe to call on any thread.

Powered by Google App Engine
This is Rietveld 408576698