Use AnalysisDriver.getCachedResult() for 'implemented' notification.

Use AnalysisDriver.getCachedResult() for 'implemented' notification.

In general case we cannot use getResult() in this notification.
We generate these notifications after analysis is complete in scheduler.
But if there is no cached result, getResult() will schedule analysis.
So, we might get into a loop.

In practice this worked, because IDEA always makes files priority,
so their results cached, and then subscribes for notifications.
But in general case we need this protection.

This also means that the 'implemented' notification works (and will
work) only for priority files.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/b3fe98537120092c455e5f44a4846ce9a82f124d

[Brian Wilkerson, 2017-06-29 16:07:17]

lgtm

[scheglov, 2017-06-29 16:57:25]

Description was changed from

==========
Use AnalysisDriver.getCachedResult() for 'implemented' notification.

In general case we cannot use getResult() in this notification.
We generate these notifications after analysis is complete in scheduler.
But if there is no cached result, getResult() will schedule analysis.
So, we might get into a loop.

In practice this worked, because IDEA always makes files priority,
so their results cached, and then subscribes for notifications.
But in general case we need this protection.

This also means that the 'implemented' notification works (and will
work) only for priority files.

R=brianwilkerson@google.com
BUG=
==========

to

==========
Use AnalysisDriver.getCachedResult() for 'implemented' notification.

In general case we cannot use getResult() in this notification.
We generate these notifications after analysis is complete in scheduler.
But if there is no cached result, getResult() will schedule analysis.
So, we might get into a loop.

In practice this worked, because IDEA always makes files priority,
so their results cached, and then subscribes for notifications.
But in general case we need this protection.

This also means that the 'implemented' notification works (and will
work) only for priority files.

R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/b3fe98537120092c455e5f44a4846ce9a82f124d
==========

[scheglov, 2017-06-29 16:57:26]

Committed patchset #1 (id:1) manually as
b3fe98537120092c455e5f44a4846ce9a82f124d (presubmit successful).