Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: components/breakpad/browser/crash_handler_host_linux.h

Issue 296553002: Breakpad Linux: Prevent some memory leaks. (Try 2) (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix asan Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/breakpad/browser/crash_handler_host_linux.h
===================================================================
--- components/breakpad/browser/crash_handler_host_linux.h (revision 271470)
+++ components/breakpad/browser/crash_handler_host_linux.h (working copy)
@@ -61,14 +61,14 @@
private:
void Init();
- // Do work on the FILE thread for OnFileCanReadWithoutBlocking().
- void WriteDumpFile(BreakpadInfo* info,
+ // Do work in a sequenced worker pool for OnFileCanReadWithoutBlocking().
+ void WriteDumpFile(scoped_ptr<BreakpadInfo> info,
+ scoped_ptr<char[]> crash_context,
pid_t crashing_pid,
- char* crash_context,
int signal_fd);
// Continue OnFileCanReadWithoutBlocking()'s work on the IO thread.
- void QueueCrashDumpTask(BreakpadInfo* info, int signal_fd);
+ void QueueCrashDumpTask(scoped_ptr<BreakpadInfo> info, int signal_fd);
std::string process_type_;
base::FilePath dumps_path_;
@@ -85,10 +85,6 @@
// by other tasks.
base::SequencedWorkerPool::SequenceToken worker_pool_token_;
-#if defined(ADDRESS_SANITIZER)
- char* asan_report_str_;
-#endif
-
DISALLOW_COPY_AND_ASSIGN(CrashHandlerHostLinux);
};

Powered by Google App Engine
This is Rietveld 408576698