Breakpad Linux: Prevent some memory leaks. (Try 2)

Breakpad Linux: Prevent some memory leaks. (Try 2)

Also sanitize renderer data more.

TBR=rsesek@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271640

[Lei Zhang, 2014-05-19 20:53:40]

Previous try reverted due to a missing delete in ASAN-only code. See difference
between patch sets 1 and 2.

[mdempsky, 2014-05-19 20:58:37]

lgtm

[Lei Zhang, 2014-05-19 21:05:12]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-05-19 21:06:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/296553002/20001

[commit-bot: I haz the power, 2014-05-19 21:06:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-19 21:06:07]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Lei Zhang, 2014-05-19 21:17:37]

TBRing rsesek again due to http://crbug.com/374571

[Lei Zhang, 2014-05-19 21:17:41]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-05-19 21:18:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/296553002/20001

[commit-bot: I haz the power, 2014-05-20 00:44:56]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-20 14:50:56]

Change committed as 271640

[jochen (gone - plz use gerrit), 2014-05-22 10:52:27]

https://codereview.chromium.org/296553002/diff/20001/components/breakpad/brow...
File components/breakpad/browser/crash_handler_host_linux.cc (right):

https://codereview.chromium.org/296553002/diff/20001/components/breakpad/brow...
components/breakpad/browser/crash_handler_host_linux.cc:303: std::string distro
= base::GetLinuxDistro();
this method crashes in thread restrictions :-/

[Lei Zhang, 2014-05-22 18:12:32]

On 2014/05/22 10:52:27, jochen wrote:
>
https://codereview.chromium.org/296553002/diff/20001/components/breakpad/brow...
> File components/breakpad/browser/crash_handler_host_linux.cc (right):
> 
>
https://codereview.chromium.org/296553002/diff/20001/components/breakpad/brow...
> components/breakpad/browser/crash_handler_host_linux.cc:303: std::string
distro
> = base::GetLinuxDistro();
> this method crashes in thread restrictions :-/

Doh. I guess that might explain why we had it the way we did before. I'll try to
fix this today.