Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2965513002: Update expectations now that #30000 is fixed. (Closed)

Created:
3 years, 5 months ago by Paul Berry
Modified:
3 years, 5 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update expectations now that #30000 is fixed. Test inference/unresolved_super now passes; it just needed an expectation file. R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/1e9c0d972264c13c91db708620abee1b1673f07e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
A pkg/front_end/testcases/inference/unresolved_super.dart.strong.expect View 1 chunk +19 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/strong.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
I only need a review from one of you
3 years, 5 months ago (2017-06-29 12:50:10 UTC) #2
ahe
lgtm
3 years, 5 months ago (2017-06-29 13:48:24 UTC) #3
Paul Berry
3 years, 5 months ago (2017-06-29 17:45:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1e9c0d972264c13c91db708620abee1b1673f07e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698