Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2965423002: Stop using ExecutableElement.functions in tests. (Closed)

Created:
3 years, 5 months ago by scheglov
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -74 lines) Patch
A pkg/analyzer/lib/src/generated/testing/node_search.dart View 1 chunk +30 lines, -0 lines 0 comments Download
M pkg/analyzer/test/dart/element/builder_test.dart View 27 chunks +60 lines, -46 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 5 chunks +16 lines, -16 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 2 chunks +11 lines, -12 lines 0 comments Download
M pkg/analyzer/test/utils.dart View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 5 months ago (2017-07-07 18:25:57 UTC) #1
Paul Berry
lgtm
3 years, 5 months ago (2017-07-07 19:05:52 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 4323722416a2b6594759d964990357ecd29b9309 (presubmit successful).
3 years, 5 months ago (2017-07-07 20:05:45 UTC) #4
Brian Wilkerson
3 years, 5 months ago (2017-07-19 16:19:07 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698