Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1031)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_target.dart

Issue 2965393002: Use FastaMessage instead of String. Part 1. (Closed)
Patch Set: Add type variable to Code. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
index 5fb5a1df2cc10f74b351cb819a03c4694f71ea51..bec1fc036422e3f5358f5a6b22577cefd7af4992 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
@@ -56,11 +56,14 @@ import '../dill/dill_target.dart' show DillTarget;
import '../deprecated_problems.dart'
show
+ deprecated_formatUnexpected,
deprecated_InputError,
deprecated_internalProblem,
reportCrash,
resetCrashReporting;
+import '../messages.dart' show LocatedMessage;
+
import '../util/relativize.dart' show relativizeUri;
import '../compiler_context.dart' show CompilerContext;
@@ -359,7 +362,7 @@ class KernelTarget extends TargetImplementation {
///
/// If there's no main library, this method uses [erroneousProgram] to
/// replace [program].
- void handleRecoverableErrors(List<deprecated_InputError> recoverableErrors) {
+ void handleRecoverableErrors(List<LocatedMessage> recoverableErrors) {
if (recoverableErrors.isEmpty) return;
KernelLibraryBuilder mainLibrary = loader.first;
if (mainLibrary == null) {
@@ -367,8 +370,9 @@ class KernelTarget extends TargetImplementation {
return;
}
List<Expression> expressions = <Expression>[];
- for (deprecated_InputError error in recoverableErrors) {
- String message = error.deprecated_format();
+ for (LocatedMessage error in recoverableErrors) {
+ String message = deprecated_formatUnexpected(
+ error.uri, error.charOffset, error.message);
errors.add(message);
expressions.add(new StringLiteral(message));
}
« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart ('k') | pkg/front_end/lib/src/fasta/loader.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698