Issue 296533004: Fix incorrect iframe loading during back/forward navigation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 296533004: Fix incorrect iframe loading during back/forward navigation. (Closed)

Created:
6 years, 7 months ago by Nate Chapin

Modified:
6 years, 7 months ago

Reviewers:
dglazkov

CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Fix incorrect iframe loading during back/forward navigation. This is a partial revert of blink r156330. It adds back in a special case for a new JS-initiated navigation before the first real load in an iframe, where we cancel the existing provisional load. BUG=374174, 348447 TEST=http/tests/navigation/back-to-dynamic-iframe.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174324

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -1 line)			Patch
A	LayoutTests/http/tests/navigation/back-to-dynamic-iframe.html	View	1	1 chunk	+34 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/navigation/back-to-dynamic-iframe-expected.txt	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
A +	LayoutTests/http/tests/navigation/resources/back-to-dynamic-iframe-iframe.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/loader/NavigationScheduler.cpp	View		1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/296533004/20001

6 years, 7 months ago (2014-05-19 21:57:04 UTC) #4

Message was sent while issue was closed.

Change committed as 174324

Expand Messages | Collapse Messages